Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25360 get test coverage and results #25394

Merged
merged 23 commits into from
Jul 5, 2023

Conversation

fmontes
Copy link
Member

@fmontes fmontes commented Jun 29, 2023

Proposed Changes

Kapture.2023-07-05.at.14.23.34.mp4

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@zJaaal
Copy link
Contributor

zJaaal commented Jul 3, 2023

Looks like you can create a shared file to avoid repeating configurations for jest
https://stackoverflow.com/questions/40726702/is-there-anyway-to-extend-a-jest-configuration-file

Copy link
Contributor

@zJaaal zJaaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@fmontes
Copy link
Member Author

fmontes commented Jul 5, 2023

Looks like you can create a shared file to avoid repeating configurations for jest https://stackoverflow.com/questions/40726702/is-there-anyway-to-extend-a-jest-configuration-file

Yes, we already have one, the problem is that we need the name of the lib or the app in the test result file and I didn't found a dynamic way to get that in the file.

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 38.8% 38.81% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@fmontes fmontes merged commit f0d0ded into master Jul 5, 2023
16 of 22 checks passed
@fmontes fmontes deleted the issue-25360-get-test-coverage-and-results branch July 5, 2023 20:25
manuelrojas pushed a commit that referenced this pull request Jul 5, 2023
* Fix #25360 Generate coverage and result tests files for core-web tests

* Add github action reporter and make some test fail

* Add jest-junit

* Setup karma lcov and junit reports

* Add settings to block-editor lib

* Fix the block-editor test names

* Add reports to data-access

* Break data-access test

* Add jest config to portlet experiments

* Add jest presets

* Clean up and add reports

* Fix experiements results

* Fix the paths

* Update default path

* Add verbose option

* Fix broken tests

* Fix test

* Fix more tests

* Remove push karma tests to github pages

* Fix data-access tests

* Add jest config to dotcdn

* Add summary report to karma and remove html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants