Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#25587 first draft for scripting role on secret tool #25588

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

jdotcms
Copy link
Contributor

@jdotcms jdotcms commented Jul 21, 2023

Adding a constraint for Scripting Developer role on velocity secrets

@jcastro-dotcms jcastro-dotcms linked an issue Aug 4, 2023 that may be closed by this pull request
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 21, 2023
@github-actions github-actions bot removed the stale label Aug 22, 2023
@jdotcms jdotcms marked this pull request as ready for review August 28, 2023 18:42
Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see feedback

Copy link
Contributor

@AndreyDotcms AndreyDotcms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes were applied, LGTM.

@dotcms-sonarqube
Copy link

@fmontes fmontes enabled auto-merge (squash) September 14, 2023 14:29
@fmontes fmontes merged commit e19679c into master Sep 14, 2023
25 of 36 checks passed
@fmontes fmontes deleted the issue-25587-script-role-on-secrets-tool branch September 14, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a role extra layer constraint into the secrets view tool
5 participants