Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing classes, tests, dependencies and updating classes related with hazelcast #25706

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

AndreyDotcms
Copy link
Contributor

@AndreyDotcms AndreyDotcms commented Aug 3, 2023

🤖 Generated by Copilot at 6ed80b7

Summary

🗑️🚀🔄

This pull request removes Hazelcast as a cache provider and cluster transport option in dotCMS, and simplifies the cache transport strategy logic. It deletes all the Hazelcast-related classes and tests, and removes the Hazelcast dependencies from the pom.xml and dependencies.gradle files. It also replaces the Hazelcast dependency with dnsjava for resolving hostnames in Kubernetes environments.

Walkthrough

  • Delete all classes related to Hazelcast cache provider and cluster transport, such as HazelcastCacheProviderClient, HazelcastCacheTransportEmbedded, HazelcastUtil, DotHazelcastListener, etc. (link, link, link, link, link, link, link, link, link, link)
  • Remove all references to Hazelcast in the pom.xml and dependencies.gradle files, and replace them with a dependency on dnsjava (link, link, link)
  • Remove all references to Hazelcast in the dotmarketing-config.properties and it-dotmarketing-config.properties files, and remove the CACHE_INVALIDATION_TRANSPORT_CLASS property (link, link)
  • Remove the imports of Hazelcast-related classes from the CacheTransportStrategy and InitServlet classes, and simplify the logic for selecting the default cache transport class to use PubSubCacheTransport for all databases (link, link, link, link)
  • Remove the cache performance tests that were specific to Hazelcast as a cache provider in dotCMS, such as CachePerformanceTest (link, link)

@AndreyDotcms AndreyDotcms linked an issue Aug 3, 2023 that may be closed by this pull request
Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nice work.

@dotcms-sonarqube
Copy link

@erickgonzalez erickgonzalez merged commit 2d7875d into master Aug 21, 2023
26 of 30 checks passed
@erickgonzalez erickgonzalez deleted the issue-24851 branch August 21, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Update : Remove Hazelcast
7 participants