Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#25636 added config property to match saml config id to a site #25762

Merged
merged 1 commit into from
Aug 16, 2023
Merged

#25636 added config property to match saml config id to a site #25762

merged 1 commit into from
Aug 16, 2023

Conversation

dsolistorres
Copy link
Contributor

@dsolistorres dsolistorres commented Aug 10, 2023 •
edited

Proposed Changes

馃 Generated by Copilot at 9677943

  • Added a feature to find a SAML identity provider configuration by its config id, which is stored as an app secret for a host.
  • The new configuration property dotcms.saml.use.idp.config.id has to be set to true to enable this feature.
  • The custom property idp.config.identifier has to be set to the config id inside the SAML App portlet for the site to be matched.
  • Updated the class DotIdentityProviderConfigurationFactoryImpl and its test cases in IdentityProviderConfigurationFactoryTest.java accordingly.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

@dsolistorres dsolistorres self-assigned this Aug 10, 2023
@dsolistorres dsolistorres force-pushed the issue-25636-map-saml-config-id-to-site-id branch from 9677943 to 14f9990 Compare August 10, 2023 19:10
@dsolistorres dsolistorres marked this pull request as ready for review August 10, 2023 19:10
@dsolistorres dsolistorres linked an issue Aug 10, 2023 that may be closed by this pull request
We require a SAML app property to map old SAML configuration IDs to site IDs #25636
Closed
@dsolistorres dsolistorres force-pushed the issue-25636-map-saml-config-id-to-site-id branch from 14f9990 to 6a06493 Compare August 11, 2023 15:10
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@erickgonzalez erickgonzalez merged commit 9163cef into master Aug 16, 2023
25 of 29 checks passed
@erickgonzalez erickgonzalez deleted the issue-25636-map-saml-config-id-to-site-id branch August 16, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickgonzalez erickgonzalez erickgonzalez approved these changes

@jcastro-dotcms jcastro-dotcms jcastro-dotcms approved these changes

@jdotcms jdotcms jdotcms approved these changes

Assignees

@dsolistorres dsolistorres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We require a SAML app property to map old SAML configuration IDs to site IDs
4 participants
@dsolistorres @erickgonzalez @jcastro-dotcms @jdotcms