New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #25862: UI Issues after CSS changes #25864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoreras
reviewed
Aug 23, 2023
hmoreras
approved these changes
Aug 23, 2023
jdotcms
approved these changes
Aug 23, 2023
SonarQube Quality Gate 0 Bugs No Coverage information |
SonarQube Quality Gate |
fmontes
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 67c0388
Summary
🎨🐛📝
This pull request improves the UI and functionality of the
dot-template-thumbnail-field
component, which allows users to select or create a thumbnail image for a template. It also fixes some related issues in the language manager portlet, the browser portlet, and the Dojo widgets that the component uses. The changes mainly involve updating the styles, layouts, and code formatting of the component and its dependencies to match the dotcms-theme library and the design mockups. The affected files aredot-template-thumbnail-field.component.scss
,searchable-dropdown.component.scss
,searchable-dropdown.component.stories.ts
,RolesFilteringSelect.html
,edit_language_keys.jsp
,_combobox.scss
,dotcms.css
, andview_browser_js_inc.jsp
.Walkthrough
dot-template-thumbnail-field.component.scss
file to reuse existing styles and avoid duplication (link)dot-template-thumbnail-field.component.scss
file to simplify the layout and use the default styles from the dotcms-theme library (link)dot-template-thumbnail-field.component.scss
file to make them more consistent with the dotcms-theme library and the design mockups (link)searchable-dropdown.component.scss
file from the view/components/_common folder to the portlets/dot-templates/dot-template-create-edit/dot-template-props/dot-template-thumbnail-field folder to make it more specific to the dot-template-thumbnail-field component and avoid affecting other components that use the searchable-dropdown component (link)searchable-dropdown.component.scss
file to apply the ellipsis style to the option label when it is too long to fit in the available width (link)searchable-dropdown.component.scss
file to make them more consistent with the dotcms-theme library and the design mockups (link)searchable-dropdown.component.stories.ts
file to avoid importing an unnecessary dependency and simplify the code (link)searchable-dropdown.component.stories.ts
file to fix a missing dependency that was causing an error in the Storybook tool (link)searchable-dropdown.component.stories.ts
file to test the ellipsis style that was added to the option label in thesearchable-dropdown.component.scss
file (link)_combobox.scss
file to make the input field more consistent with the dotcms-theme library and the design mockups (link)dotcms.css
file to make the input field more consistent with the dotcms-theme library and the design mockups (link)RolesFilteringSelect.html
file to remove an unnecessary element and style that was causing some layout issues (link, link)view_browser_js_inc.jsp
file to remove the fixed width and let the dialog adjust to the content size (link)edit_language_keys.jsp
file to improve the code formatting and readability (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)edit_language_keys.jsp
file to fix some layout issues and make the portlet more responsive (link)edit_language_keys.jsp
file to make them more consistent with the dotcms-theme library and the design mockups (link, link)edit_language_keys.jsp
file to fix a bug that was causing the language selector to show the wrong flag image (link)edit_language_keys.jsp
file to fix a layout issue that was causing the progress bar to overlap with the toolbar (link)edit_language_keys.jsp
file to fix a layout issue that was causing the pagination buttons to be misaligned (link)edit_language_keys.jsp
file to fix a bug that was causing the savingKeysDialog widget to show a close button (link)Screenshots
Screen.Recording.2023-08-23.at.11.39.33.AM.mov