Fix #26314: Edit Page UrlContentMap Fix regeneration of menu items for new dropdown #26453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g inside the iframe
zJaaal
requested review from
hmoreras,
fmontes,
oidacra,
manuelrojas,
rjvelazco and
KevinDavilaDotCMS
fmontes
approved these changes
Oct 18, 2023
rjvelazco
approved these changes
Oct 19, 2023
oidacra
approved these changes
Oct 19, 2023
hmoreras
approved these changes
Oct 19, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 6f36e95
Summary
✅✨🔧
This pull request adds conditional logic and tests for displaying the menu items for editing the URL content map in the edit page mode. This is part of the feature to allow users to edit the content associated with a URL in both the content and the SEO tabs. The changes affect the
dot-edit-page-state-controller.component.ts,dot-edit-page-state-controller-seo.component.ts, and their respective spec files.Walkthrough
menuItemsarray to empty array in both components to avoid errors (link, link)Screenshots
Screen.Recording.2023-10-18.at.1.43.19.PM.mov