fix(CLI): Fixing RemoteTraversalServiceIT intermittent tests #27527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the dotCMS remote location traversal process to incorporate parallel execution of tasks using a ManagedExecutor. Removed unnecessary imports, adjusted the exception handling methods, enhanced test stability by sorting files and folders before assertion, and other necessary logic modifications.
…-blinking-test-RemoteTraversalServiceIT
…-blinking-test-RemoteTraversalServiceIT
…ava concurrency mechanisms with ManagedExecutor
…-blinking-test-RemoteTraversalServiceIT
…ava concurrency mechanisms with ManagedExecutor
…` class to return an empty map instead of null allowing proper comparison between local descriptors and server content types.
…-blinking-test-RemoteTraversalServiceIT
Moved common functionality of FilesTree and FilesLs into new AbstractFilesListingCommand for code reuse and simplified their implementations appropriately. The changes aim to improve maintainability and code clarity by avoiding repetition.
Glob pattern options for including or excluding files and folders have been refactored into a mixin class, FilesGlobMixin. This change enhances code reusability and modularity, making the pattern options more accessible across different classes without the need for replication.
…d as duplicated.
…-blinking-test-RemoteTraversalServiceIT
This was
linked to
issues
Feb 13, 2024
fabrizzio-dotCMS
approved these changes
Feb 14, 2024
tools/dotcms-cli/cli/src/main/java/com/dotcms/api/client/FileHashCalculatorService.java
Outdated
Show resolved
Hide resolved
tools/dotcms-cli/cli/src/test/java/com/dotcms/api/client/FileHashCalculatorServiceTest.java
Show resolved
Hide resolved
...s-cli/cli/src/main/java/com/dotcms/api/client/files/traversal/LocalTraversalServiceImpl.java
Show resolved
Hide resolved
tools/dotcms-cli/cli/src/main/java/com/dotcms/api/client/task/TaskProcessor.java
Show resolved
Hide resolved
…ce exposed as an interface.
nollymar
approved these changes
Feb 14, 2024
nollymar
deleted the
issue-26633-CLI-Fix-blinking-test-RemoteTraversalServiceIT
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27540
This fix involves refactoring our existing asynchronous task execution model to leverage ManagedExecutor. This change will ensure that context is properly captured and propagated across asynchronous boundaries, maintaining consistent behavior across our application.
Specific changes include: