Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 27909 check roles before access #27912

Merged
merged 5 commits into from Mar 12, 2024

Conversation

wezell
Copy link
Contributor

@wezell wezell commented Mar 8, 2024

Updates the WebResouce to specifically check for the existence of the CMS_Admin role if it is in the required Roles List.

@wezell wezell changed the title Issue 27909 check roles before access2 Issue 27909 check roles before access Mar 8, 2024
@wezell wezell marked this pull request as ready for review March 8, 2024 18:40
@sfreudenthaler sfreudenthaler linked an issue Mar 8, 2024 that may be closed by this pull request
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@erickgonzalez erickgonzalez added this pull request to the merge queue Mar 12, 2024
Merged via the queue into master with commit 753a203 Mar 12, 2024
37 of 38 checks passed
@erickgonzalez erickgonzalez deleted the issue-27909-check-roles-before-access2 branch March 12, 2024 20:46
manuelrojas pushed a commit that referenced this pull request Mar 14, 2024
* fix(security) always checks CMS_ADMIN role before granting access to resource

ref: #27909

* fix(security) always checks CMS_ADMIN role before granting access to resource

ref: #27909

* fix(security) testing cmsAdmin access

ref: #27909

* fix(security) testing cmsAdmin access

ref: #27909

* fix(security) sonarqube feedback, complexity ref: #27909
@sfreudenthaler
Copy link
Contributor

resolved dotcms/private-issues#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Invalid role check when accessing resource
4 participants