-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#27979 New lang vars endpoint and findAllVariables methods #28429
#27979 New lang vars endpoint and findAllVariables methods #28429
Conversation
….com/dotCMS/core into issue-27979-lang-vars-backend-take-2
….com/dotCMS/core into issue-27979-lang-vars-backend-take-2
dotCMS/src/main/java/com/dotcms/languagevariable/business/LanguageVariableAPIImpl.java
Outdated
Show resolved
Hide resolved
dotCMS/src/main/java/com/dotmarketing/portlets/languagesmanager/business/LanguageCacheImpl.java
Show resolved
Hide resolved
dotCMS/src/main/java/com/dotmarketing/portlets/languagesmanager/business/LanguageCacheImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reslove the 8 new issues showing in Sonarqubue mostly repeated contestants and assert parameters the wrong way around.
they should also show in IntelliJ if you have sonar lint enabled,
and pulling out the repeated strings should be easy if you right click and use the IntellJ Refactor -> Introduce Constant option. https://sonarqube.dotcms.site/project/issues?id=dotCMS_core_AYSbIemxK43eThAXTlt-&pullRequest=28429&resolved=false
….com/dotCMS/core into issue-27979-lang-vars-backend-take-2
done @spbolton |
Quality Gate passedIssues Measures |
Talked to Steve. He is aware that modifying EContentletAPIImpl to apply soanr feedback always makes sonrar detect more problems and request more changes
Proposed Changes