Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 28596 use add-opens and set --illegal-access=deny in preparation for Java 21 #28619

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented May 21, 2024

Proposed Changes

  • Fix tika api versioning and tie it to build/release
  • Add required add-opens parameters to work around illegal access issues and set set —illegal-access=deny to replicate J21 behavior
  • Make ContentTypeUtilsTest succeed regardless of the parameter order returned which is JVM dependent.
  • Add junit-jupiter-suite and junit-platform-suite dependencies to prepare for Junit4 → Junit 5 migration of Current Suite classes and DataProvider test cases
  • Normalize some duplicate definitions of Java version to reduce changes when a change is made.
  • Upgrade dnsjava to 3.5.3 that supports java 21 without extra add-opens.

Tests: Should focus on any issues with bundles due to the serialization and deserialization and errors in logs indicating there is illegal access to internal classes. Serialization during caching would also be a concern area and reporting of cache sizes.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@spbolton spbolton changed the title Issue 28596 analyze classes in java 11 Issue 28596 use add-opens and set --illegal-access=deny in preparation for Java 21 Jun 3, 2024
@spbolton spbolton force-pushed the issue-28596-analyze-classes-in-java-11-failing-with-illegal-ac branch from f248f4a to cae24a6 Compare June 3, 2024 16:18
@spbolton spbolton force-pushed the issue-28596-analyze-classes-in-java-11-failing-with-illegal-ac branch from cae24a6 to 2499942 Compare June 3, 2024 17:42
Copy link

@spbolton spbolton marked this pull request as ready for review June 4, 2024 16:30
@spbolton spbolton requested review from wezell and dcolina June 4, 2024 16:30
@spbolton spbolton enabled auto-merge June 4, 2024 16:35
@spbolton spbolton added this pull request to the merge queue Jun 4, 2024
Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests working.

Merged via the queue into master with commit b9580d2 Jun 4, 2024
27 checks passed
@spbolton spbolton deleted the issue-28596-analyze-classes-in-java-11-failing-with-illegal-ac branch June 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyze Classes in Java 11 failing with illegal-access=deny and create add-opens parameters
4 participants