-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): dotCMS client general cleanup #28711 #28731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
oidacra,
nicobytes,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
June 3, 2024 13:45
oidacra
reviewed
Jun 3, 2024
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Show resolved
Hide resolved
oidacra
approved these changes
Jun 3, 2024
This reverts commit 45386d0.
hmoreras
approved these changes
Jun 4, 2024
fmontes
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this comments can be done in another PR if you want to.
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Show resolved
Hide resolved
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/client/src/lib/client/content/builders/collection/collection.ts
Show resolved
Hide resolved
zJaaal
force-pushed
the
28711-sdk-dotcms-client-general-cleanup
branch
from
June 6, 2024 13:56
86c1b4c
to
a0d85f9
Compare
Quality Gate passedIssues Measures |
fmontes
approved these changes
Jun 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
QueryBuilderCallback
toBuildQuery
for better understandingquery
method to support bothstring
andbuildQuery
callbackcontent/methods/get-collection
tocontent/builders/collection
GetCollection
toCollectionBuilder
then
method directly from the builder or use async/await without further calls of methodsExample of how to fetch content