Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Cache SDKMan java and fix run-id passing #29247

Merged
merged 10 commits into from
Jul 17, 2024
Merged

ci: Cache SDKMan java and fix run-id passing #29247

merged 10 commits into from
Jul 17, 2024

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented Jul 17, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Cache java from SDKMan to prevent issues from flakey downloads
  • add missing "needs" declaration to be able to pass merge queue run id in a couple of cases

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

This PR fixes: #27998

@spbolton spbolton requested a review from a team as a code owner July 17, 2024 09:28
dcolina
dcolina approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dcolina dcolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@spbolton spbolton force-pushed the issue-27998-task-update-workflow-to-support-any-java-version branch from 6e148a9 to 1ddf737 Compare July 17, 2024 09:57
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@spbolton spbolton enabled auto-merge July 17, 2024 16:37
@spbolton spbolton disabled auto-merge July 17, 2024 16:55
@spbolton spbolton added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 3c24f30 Jul 17, 2024
17 checks passed
@spbolton spbolton deleted the issue-27998-task-update-workflow-to-support-any-java-version branch July 17, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcolina dcolina dcolina approved these changes

@fabrizzio-dotCMS fabrizzio-dotCMS fabrizzio-dotCMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Update Workflow to Support Any Java Version Using SDKMAN
3 participants
@spbolton @dcolina @fabrizzio-dotCMS