-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dedupeFragments
config flag for dealing with duplicate fragments
#6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c695e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are not available as alpha, since there are no linked |
Thoughts on that:
Todayconst fragmentB = `fragment B on B { ... }`;
const fragmentA = `fragment A on A { field { ...B } } ${fragmentB}`;
const query = `query { ...B, ...A } ${fragmentA} ${fragmentB}` What I suggest, is to do: const fragmentB = `fragment B on B { ... }`;
const fragmentA = `fragment A on A { field { ...B } }`; // No template literals here
const query = `query { ...B, ...A } ${fragmentA} ${fragmentB}` // Only here |
b0017bd
to
92931a1
Compare
dotansimha
approved these changes
Jun 13, 2021
packages/plugins/other/visitor-plugin-common/src/base-visitor.ts
Outdated
Show resolved
Hide resolved
packages/plugins/typescript/typed-document-node/tests/typed-document-node.spec.ts
Show resolved
Hide resolved
2057352
to
1c695e5
Compare
dedupeFragments
config flag for dealing with duplicate fragments
dotansimha
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4684