fix(typescript-operations): properly handle aliased conditionals

[henryqdineen]

Description

We use GraphQL code generator heavily at our company and today ran into an issue where a field was conditional (using @include directive) but the types show it as being always present in the response.

Related issue: #8461

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added a unit test to ts-documents.spec.ts

Test Environment:

• OS: Sonoma
• NodeJS: v16.13.2

Checklist:

• I have followed the CONTRIBUTING doc and the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Further comments

It's not clear if this fix wasn't made earlier. Was there some limitation that previous fixes ran into? I don't see any discussion in the original issue.

[changeset-bot]

🦋 Changeset detected

Latest commit: 18d4f3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@graphql-codegen/visitor-plugin-common	Patch
@graphql-codegen/typescript-operations	Patch
@graphql-codegen/typescript-document-nodes	Patch
@graphql-codegen/gql-tag-operations	Patch
@graphql-codegen/typescript-resolvers	Patch
@graphql-codegen/typed-document-node	Patch
@graphql-codegen/typescript	Patch
@graphql-codegen/graphql-modules-preset	Patch
@graphql-codegen/client-preset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[saihaj]

can you please create a changeset using yarn changeset and select appropriate package. Learn more about changeset

[henryqdineen]

can you please create a changeset using yarn changeset and select appropriate package. Learn more about changeset

All set. Thanks!

[saihaj]

Thanks!