Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditches leak-canary for now #676

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Ditches leak-canary for now #676

merged 1 commit into from
Sep 22, 2022

Conversation

ubiratansoares
Copy link
Member

@ubiratansoares ubiratansoares commented Sep 22, 2022

Description

Describe your changes in detail
Why is this change required? What problem does it solve?
If it fixes an open issue, please put a link to the issue here.

We'll migrate to the new approach introduced at v2.8+ afterwards, since it has a couple gotchas

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • House cleaning
  • Bug fix
  • Enhancement
  • Breaking change
  • New feature
  • New release
  • Documentation

Additional details

Please, list here some additional details we should be aware of when reviewing your PR.

N/A

@ubiratansoares ubiratansoares self-assigned this Sep 22, 2022
@mergify mergify bot merged commit 22d195e into master Sep 22, 2022
@mergify mergify bot deleted the ufs/ditches-leakcanary branch September 22, 2022 15:59
@runforesight
Copy link

runforesight bot commented Sep 22, 2022

Foresight Workflow Report

CI workflow has finished in 10 minutes 59 seconds and finished at 22nd Sep, 2022. Conclusion: SUCCESS. Here is the analysis:


Job Failed Steps Tests Not tested changed lines*
features-lookup -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
static-analysis -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
assemble-apk (jdk11) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
assemble-apk (jdk17) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
espresso-prepare (jdk11) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
espresso-prepare (jdk17) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
unit-tests (jdk11) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
unit-tests (jdk17) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
app-size-analysis -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
security-analysis -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
acceptance-tests (NexusLowRes) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
acceptance-tests (Pixel2) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
screenshot-tests (facts) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
screenshot-tests (search) -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details
test-results-analysis -     🔗  ✅ -  ❌ -  ⏭ -     N/A    See Details

*Not tested changed lines calculated for determining how much of the changes are covered by the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant