add SourceLink support to the library

[marfenij]

Hi again )
This is other awesome stuff which must present in each library IMHO.

I'm not familiar with codecov.io, but think this change should not break anything

[marfenij]

Hi @dotarj
any notes for that PR ?

[dotarj]

Hi @marfenij, I'm not sure what the consequences of this change would be. I see that the assembly is larger, which is logical, but could there be any negative impact on performance? And what is effect on debugging in other software than Visual Studio 2017 (Visual Studio Code or Rider for example)?

[marfenij]

I embedded PDB not used in runtime, it used for debug purpose.

That author of SourceLink write on Github

about VS Code:

• OmniSharp plugin (Debugger should support symbol and source server dotnet/vscode-csharp#373 (comment))

about Rider:

• I can't find any proof that this feature supported by it, but R# and .Peek allow to used that - mb Rider also support... I don't use Rider so can't check that

[dotarj]

Hi @marfenij, I'll try to read some more about SourceLink and run some tests this weekend. If everything is ok, I'll merge the PR after that.

[dotarj]

Hi @marfenij, I've had some trouble building protobuf-net-data when source link was enabled. Apparently, source link uses the command 'git rev-parse --show-toplevel' which failed because my machine was badly configured. That's resolved and everything looks good. One question though: shouldn't the argument -p:IncludeSymbols=true be removed for the msbuild -t:pack command?

[marfenij]

@dotarj hi. I think need remove msbuild parameter, but I need also resolve conficts

[dotarj]

Ok, if you remove the argument, I'll resolve the conflicts. 😃

[marfenij]

@dotarj these conflicts is not deadly, let's try check if you fix appveyor script

[dotarj]

All systems go! 😄 Only the -p:IncludeSymbols=true argument still has to be removed, but I'll do that in another commit. Thanks for the contribution!

[marfenij]

@dotarj I stuck with internet and can't build solution - nuget can't restored

But you do it ))))