2089 fix restart runtime error

[pnasrat]

Tested with unittest and latest reproducer in bug.

root@precise64:/vagrant# ID=$(docker run -d busybox sleep 60)
root@precise64:/vagrant# invoke-rc.d docker restart
invoke-rc.d: unknown initscript, /etc/init.d/docker not found.
root@precise64:/vagrant# docker kill $ID
68cfb88cf047
root@precise64:/vagrant# docker start $ID
68cfb88cf047
root@precise64:/vagrant# docker ps
ID                  IMAGE               COMMAND             CREATED             STATUS              PORTS
68cfb88cf047        busybox:latest      sleep 60            10 seconds ago      Up 8 seconds

[pnasrat]

Issue #2089

[tianon]

Oops, I forgot that invoke-rc.d only works for init scripts (not upstart). If you replace that with service docker restart it will probably not error out and should give you a ghost like it's supposed to.

[pnasrat]

I actually just copied and pasted the wrong block (I reran with initctl stop). Let me just confirm that.

[pnasrat]

# ID=$(docker run -d busybox sleep 600)
Unable to find image 'busybox' (tag: latest) locally
Pulling repository busybox
e9aa60c60128: Download complete
# service docker restart
docker stop/waiting
docker start/running, process 10109
# docker kill $ID
8b4af5160c62
# docker inspect $ID | grep Ghost
        "Ghost": true
# docker start $ID
8b4af5160c62
# docker -v
Docker version 0.6.4-dev, build 877be37-dirty
# docker ps
ID                  IMAGE               COMMAND             CREATED              STATUS              PORTS
8b4af5160c62        busybox:latest      sleep 600           About a minute ago   Up 52 seconds

[tianon]

Cool! Major +1 from me for taking care of this! (although, IANTM)

[vieux]

Are you sure about the || ? the if is now always returning true.

[pnasrat]

Meh I could have messed this up. I won't have time to look at until this evening.

I believe that if we have a non-running ghost we should create the network, let me add a test for the happy path and figure it out.

[pnasrat]

@vieux please take another look - I've made an explicit nil network ip check and both unit and manual test still passes.

[vieux]

LGTM, ping @crosbymichael

[pnasrat]

Need to rebase having some test failure issues. Will ping PR when fixed.

[pnasrat]

Have fixed up and my test passes with the signature change but getting failures

https://gist.github.com/pnasrat/d1fcd6bab3d2028c6c82

@ecnahc515 is also seeing the lxc-kill failures

[pnasrat]

Actually I misread the output and it passes after I updated the host docker to be the same version https://gist.github.com/pnasrat/d1fcd6bab3d2028c6c82

@crosbymichael should be ready for review.

[crosbymichael]

LGTM