-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vm port forwarding note/example in osx install docs #4020
Conversation
Can you please sign their commits following these rules: https://github.com/dotcloud/docker/blob/master/CONTRIBUTING.md#sign-your-work Each commit in your PR must be signed in the following format: Please rebase and sign each commit. |
Thanks, all done. |
mmm, @CameronBoehmer looks like travis doesn't like it - there's probably a space or a return out of place :( can you add a little to point out that |
Good idea. Updated the example to use that range, as well. |
LGTM, though I don't know that we should be linking to an external blog for the example |
Docker-DCO-1.1-Signed-off-by: Cameron Boehmer <cameron.boehmer@gmail.com> (github: cameronboehmer)
On second thought, I agree. Link removed. |
Thanks for the helpful tip. LGTM. Merging. |
add vm port forwarding note/example in osx install docs
Why is this not done when the vm is created by the boot2docker script? |
@Pyrolistical Because this could have a hugely negative impact on the VM host. |
.. code-block:: bash | ||
|
||
# vm must be powered off | ||
for i in {4900..49900}; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
for i in {49000..49900}; do
(49000 instead of 4900)?
No description provided.