Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vm port forwarding note/example in osx install docs #4020

Merged
merged 1 commit into from
Feb 12, 2014

Conversation

cameron
Copy link
Contributor

@cameron cameron commented Feb 9, 2014

No description provided.

@SvenDowideit
Copy link
Contributor

Can you please sign their commits following these rules: https://github.com/dotcloud/docker/blob/master/CONTRIBUTING.md#sign-your-work

Each commit in your PR must be signed in the following format:
Docker-DCO-1.1-Signed-off-by: Joe Smith <joe.smith@email.com> (github: github_handle)

Please rebase and sign each commit.

@cameron
Copy link
Contributor Author

cameron commented Feb 11, 2014

Thanks, all done.

@SvenDowideit
Copy link
Contributor

mmm, @CameronBoehmer looks like travis doesn't like it - there's probably a space or a return out of place :(

can you add a little to point out that 49000..49900 are what Docker is likely to use then you use the -P option?

@cameron
Copy link
Contributor Author

cameron commented Feb 11, 2014

Good idea. Updated the example to use that range, as well.

@SvenDowideit
Copy link
Contributor

LGTM, though I don't know that we should be linking to an external blog for the example

@metalivedev @jamtur01

Docker-DCO-1.1-Signed-off-by: Cameron Boehmer <cameron.boehmer@gmail.com> (github: cameronboehmer)
@cameron
Copy link
Contributor Author

cameron commented Feb 11, 2014

On second thought, I agree. Link removed.

@metalivedev
Copy link
Contributor

Thanks for the helpful tip. LGTM. Merging.

metalivedev added a commit that referenced this pull request Feb 12, 2014
add vm port forwarding note/example in osx install docs
@metalivedev metalivedev merged commit 3122b4b into moby:master Feb 12, 2014
@Pyrolistical
Copy link

Why is this not done when the vm is created by the boot2docker script?

@cpuguy83
Copy link
Member

@Pyrolistical Because this could have a hugely negative impact on the VM host.
In the latest version of boot2docker this is not even required anymore to get connectivity to the running containers.

.. code-block:: bash

# vm must be powered off
for i in {4900..49900}; do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

for i in {49000..49900}; do

(49000 instead of 4900)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants