Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key without value fixer #254

Merged
merged 3 commits into from Aug 11, 2020
Merged

Add key without value fixer #254

merged 3 commits into from Aug 11, 2020

Conversation

unexge
Copy link
Contributor

@unexge unexge commented Aug 10, 2020 •
edited

✔ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

fixes #247

@DDtKey DDtKey requested a review from a team August 10, 2020 19:56
@mgrachev mgrachev added this to the v2.2.0 milestone Aug 11, 2020
mgrachev
mgrachev approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@mgrachev mgrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unexge 👋 Thank you for your contribution! 🚀

@DDtKey Please take a look at this PR 🙂

DDtKey
DDtKey approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR ☺️

src/fixes.rs
blank_line_entry(3, 3),
];
let mut warnings = vec![Warning::new(
lines[1].clone(),
"KeyWithoutValue",
String::from("The C key should be with a value or have an equal sign"),
"Unfixable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that in the future we should remove this test (when all checks will have Fixer).
At the moment use unreachable check name is ok :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right 👍

@mgrachev mgrachev merged commit 8c8754c into dotenv-linter:master Aug 11, 2020
@mgrachev
Copy link
Member

@unexge Thank you! 🦀

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

@unexge unexge deleted the feature/key_without_value_fixer branch August 11, 2020 17:23
@DDtKey DDtKey mentioned this pull request Aug 14, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Add fixer: KeyWithoutValueFixer
3 participants
@unexge @mgrachev @DDtKey