-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key without value fixer #254
Merged
mgrachev
merged 3 commits into
dotenv-linter:master
from
unexge:feature/key_without_value_fixer
Aug 11, 2020
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
use super::Fix; | ||
use crate::common::*; | ||
|
||
pub(crate) struct KeyWithoutValueFixer<'a> { | ||
name: &'a str, | ||
} | ||
|
||
impl Default for KeyWithoutValueFixer<'_> { | ||
fn default() -> Self { | ||
Self { | ||
name: "KeyWithoutValue", | ||
} | ||
} | ||
} | ||
|
||
impl Fix for KeyWithoutValueFixer<'_> { | ||
fn name(&self) -> &str { | ||
self.name | ||
} | ||
|
||
fn fix_line(&self, line: &mut LineEntry) -> Option<()> { | ||
line.raw_string.push('='); | ||
|
||
Some(()) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
use std::path::PathBuf; | ||
|
||
#[test] | ||
fn fix_line_test() { | ||
let fixer = KeyWithoutValueFixer::default(); | ||
let mut line = LineEntry { | ||
number: 1, | ||
file: FileEntry { | ||
path: PathBuf::from(".env"), | ||
file_name: ".env".to_string(), | ||
total_lines: 1, | ||
}, | ||
raw_string: String::from("FOO"), | ||
}; | ||
assert_eq!(Some(()), fixer.fix_line(&mut line)); | ||
assert_eq!("FOO=", line.raw_string); | ||
} | ||
|
||
#[test] | ||
fn fix_warnings_test() { | ||
let fixer = KeyWithoutValueFixer::default(); | ||
let mut lines = vec![ | ||
LineEntry { | ||
number: 1, | ||
file: FileEntry { | ||
path: PathBuf::from(".env"), | ||
file_name: ".env".to_string(), | ||
total_lines: 3, | ||
}, | ||
raw_string: String::from("FOO"), | ||
}, | ||
LineEntry { | ||
number: 2, | ||
file: FileEntry { | ||
path: PathBuf::from(".env"), | ||
file_name: ".env".to_string(), | ||
total_lines: 3, | ||
}, | ||
raw_string: String::from("Z=Y"), | ||
}, | ||
LineEntry { | ||
number: 3, | ||
file: FileEntry { | ||
path: PathBuf::from(".env"), | ||
file_name: ".env".to_string(), | ||
total_lines: 3, | ||
}, | ||
raw_string: String::from("\n"), | ||
}, | ||
]; | ||
let mut warning = Warning::new( | ||
lines[0].clone(), | ||
"KeyWithoutValue", | ||
String::from("The FOO key should be with a value or have an equal sign"), | ||
); | ||
|
||
assert_eq!(Some(1), fixer.fix_warnings(vec![&mut warning], &mut lines)); | ||
assert_eq!("FOO=", lines[0].raw_string); | ||
assert!(warning.is_fixed); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that in the future we should remove this test (when all checks will have
Fixer
).At the moment use unreachable check name is ok :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right 👍