Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for new version #454

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Add check for new version #454

merged 1 commit into from
Jan 3, 2022

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Dec 30, 2021

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev changed the title feat: add check for new version Add check for new version Dec 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #454 (850cdf1) into master (7b990e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   98.87%   98.88%           
=======================================
  Files          41       41           
  Lines        2676     2697   +21     
=======================================
+ Hits         2646     2667   +21     
  Misses         30       30           
Impacted Files Coverage Δ
src/common/quote_type.rs 100.00% <ø> (ø)
src/cli.rs 100.00% <100.00%> (ø)
src/lib.rs 98.48% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b990e4...850cdf1. Read the comment docs.

@github-actions
Copy link

Benchmark for 55d63d9

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 59.9±0.36µs 50.9±0.18µs +17.68%
dotenv_linter compare 43.5±0.22µs 43.7±0.18µs -0.46%
dotenv_linter fix 172.6±224.49µs 137.5±85.61µs +25.53%
dotenv_linter fix with backup 178.0±106.96µs 190.8±134.22µs -6.71%

@github-actions
Copy link

Benchmark for 9af2096

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 73.1±4.93µs 66.9±3.28µs +9.27%
dotenv_linter compare 57.2±3.61µs 55.2±3.89µs +3.62%
dotenv_linter fix 204.2±69.13µs 203.0±63.02µs +0.59%
dotenv_linter fix with backup 286.3±236.73µs 302.7±260.63µs -5.42%

@mgrachev mgrachev changed the title Add check for new version WIP: Add check for new version Dec 30, 2021
@github-actions
Copy link

Benchmark for 882a902

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 74.0±11.26µs 61.5±3.01µs +20.33%
dotenv_linter compare 54.1±2.71µs 52.7±4.14µs +2.66%
dotenv_linter fix 209.3±159.05µs 195.4±34.93µs +7.11%
dotenv_linter fix with backup 275.2±132.86µs 265.6±211.63µs +3.61%

@mgrachev mgrachev requested a review from a team December 31, 2021 11:28
@mgrachev mgrachev changed the title WIP: Add check for new version Add check for new version Dec 31, 2021
Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Benchmark for d2eb012

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 60.0±0.20µs 51.5±0.15µs +16.50%
dotenv_linter compare 44.0±0.21µs 44.0±0.31µs 0.00%
dotenv_linter fix 146.3±118.52µs 157.1±150.77µs -6.87%
dotenv_linter fix with backup 177.0±84.88µs 175.2±106.54µs +1.03%

src/lib.rs Show resolved Hide resolved
@mgrachev mgrachev merged commit a1f0cc1 into master Jan 3, 2022
@mgrachev mgrachev deleted the check-updates branch January 3, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants