Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storybook to latest such that source code formatting works #130

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

niklasmh
Copy link
Member

@niklasmh niklasmh commented Nov 13, 2019

Storybook has fixed a lot lately and among them, it fixes #99

Now:
image

@niklasmh niklasmh added Priority: Low Bug Something that just ain't right labels Nov 13, 2019
@niklasmh niklasmh self-assigned this Nov 13, 2019
@niklasmh
Copy link
Member Author

I would think it is better for us to just wait for version 5.3.0 as things could be a little unstable in 5.3.0-alpha.44 (just assuming) and a formatting bug is not that much of a big deal.

@niklasmh
Copy link
Member Author

Let us just keep this PR open until 5.3.0 is released, then update the branch with the actual version (duh), then merge it.

@plusk
Copy link
Member

plusk commented Jan 27, 2020

5.3 is released now, see blog post here

@plusk plusk merged commit 554c884 into master Feb 5, 2020
@plusk plusk deleted the fix/code-formatting-and-probably-other-bugs branch February 5, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that just ain't right Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indent issue on story source codes
2 participants