Skip to content

Commit

Permalink
Fix mixins with nested rulesets using parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesfoster-excelpoint committed Apr 28, 2010
1 parent 2c50c4c commit ae2f1cb
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 3 deletions.
6 changes: 4 additions & 2 deletions src/dotless.Core/engine/LessNodes/NodeBlock.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,12 @@ public virtual INode AdoptClone(INode newParent)

public INode AdoptClone(INode newParent, INode oldParent)
{
var children = Children.Select(n => n.AdoptClone(newParent, oldParent)).ToList();

var clone = (NodeBlock)MemberwiseClone();

var children = Children.Select(n => n.AdoptClone(clone, this)).ToList();

clone.Children = children;
clone.Parent = newParent;

return clone;
}
Expand Down
23 changes: 22 additions & 1 deletion src/dotless.Test/Spec/Mixin/MixinFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,28 @@ public void CanNestRulesInParameterizedMixins()

AssertLess(css, less);
}


[Test]
public void CanUseParametersInNestedRules()
{
var less = @"
.mixin(@a: 5) {
nested-rule {
width: @a;
}
}
.class1 { .mixin(7); }
.class2 { .mixin(8); }
";

var css = @"
.class1 nested-rule { width: 7; }
.class2 nested-rule { width: 8; }
";

AssertLess(css, less);
}

[Test]
public void CanUseVariablesAsDefaultArgumentValues()
{
Expand Down

0 comments on commit ae2f1cb

Please sign in to comment.