Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Azdevify eshopOnWeb #844

Merged
merged 47 commits into from
Aug 25, 2023
Merged

Azdevify eshopOnWeb #844

merged 47 commits into from
Aug 25, 2023

Conversation

zedy-wj
Copy link
Contributor

@zedy-wj zedy-wj commented Jan 31, 2023

This pr is all changes to convert eShopOnWeb application into an Azd template.

You can currently deploy the eShopOnWeb application using azd by following the steps below:

  1. azd up -t https://github.com/zedy-wj/eShopOnWeb.git -b main
  2. Wait a moment for the resource deployment to complete, click the web endpoint and you will see:
    image

@jongio, @rajeshkamal5050 for notification.

@erjain
Copy link
Contributor

erjain commented Mar 21, 2023

Hi @jongio, Are we good to merge the PR?

@jongio
Copy link
Contributor

jongio commented Mar 21, 2023

I'll have a look soon

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Web/AzureDeveloperCliCredential.cs Outdated Show resolved Hide resolved
infra/core/database/sqlserver/sqlserver.bicep Show resolved Hide resolved
@zedy-wj
Copy link
Contributor Author

zedy-wj commented Mar 27, 2023

@jongio We have updated according to your comments, please re-review it, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@zedy-wj
Copy link
Contributor Author

zedy-wj commented Mar 28, 2023

@jongio Updated based on your suggestions, please re-review it, thanks!

@jongio
Copy link
Contributor

jongio commented Apr 19, 2023

@zedy-wj - Can you see about the merge conflicts in this PR?

@zedy-wj
Copy link
Contributor Author

zedy-wj commented Apr 20, 2023

@jongio - The latest code has been synchronized.

@jongio
Copy link
Contributor

jongio commented Apr 20, 2023

@erjain - Do you want to run the 'deploy with azd' steps in the new readme and test it?

You'll want to either clone the branch and run azd FROM THIS BRANCH or use the -b flag if you choose to use azd init.

@jongio
Copy link
Contributor

jongio commented Jun 7, 2023

@jamesmontemagno - You good with merging this?

@jamesmontemagno
Copy link
Contributor

@SrushtiPasari94 are you able to pull this branch down and test locally.

@SrushtiPasari94
Copy link
Contributor

@jamesmontemagno I am able to pull the branch and test locally on local docker desktop. Working fine

@jamesmontemagno
Copy link
Contributor

@SrushtiPasari94 did you try it with the AZD CLI?

aka.. azd up ?

See: https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/

@jongio
Copy link
Contributor

jongio commented Aug 16, 2023

@SrushtiPasari94
Copy link
Contributor

Thanks @jongio for the update.
@jongio Can we add a note in the instruction steps that resource group name created in azure portal will be rg-{env name}

@jamesmontemagno I did tried with the AZD CLI , All the resources are getting deployed as expected with the infra template. And the website for eshopOnWeb is working as expected.

@jongio
Copy link
Contributor

jongio commented Aug 22, 2023

@zedy-wj - Can you please see Srushti's comment above and add that? Thanks

@jamesmontemagno
Copy link
Contributor

Perfect, once that is done, @SrushtiPasari94 can pull this in.

@zedy-wj
Copy link
Contributor Author

zedy-wj commented Aug 23, 2023

I have updated according to @SrushtiPasari94 comment, could you take a look and merge it? Thanks!

@SrushtiPasari94 SrushtiPasari94 merged commit 4355c53 into dotnet-architecture:main Aug 25, 2023
1 check passed
@zedy-wj zedy-wj mentioned this pull request Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants