-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Conversation
Update bicep add azure.yaml scripts
Azdevify eshopOnWeb
Hi @jongio, Are we good to merge the PR? |
I'll have a look soon |
@jongio We have updated according to your comments, please re-review it, thanks! |
@jongio Updated based on your suggestions, please re-review it, thanks! |
@zedy-wj - Can you see about the merge conflicts in this PR? |
@jongio - The latest code has been synchronized. |
@erjain - Do you want to run the 'deploy with azd' steps in the new readme and test it? You'll want to either clone the branch and run azd FROM THIS BRANCH or use the |
@jamesmontemagno - You good with merging this? |
@SrushtiPasari94 are you able to pull this branch down and test locally. |
@jamesmontemagno I am able to pull the branch and test locally on local docker desktop. Working fine |
@SrushtiPasari94 did you try it with the AZD CLI? aka.. azd up ? See: https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/ |
@SrushtiPasari94 / @jamesmontemagno - The azd related steps are in the PR README https://github.com/dotnet-architecture/eShopOnWeb/pull/844/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R44 |
Thanks @jongio for the update. @jamesmontemagno I did tried with the AZD CLI , All the resources are getting deployed as expected with the infra template. And the website for eshopOnWeb is working as expected. |
@zedy-wj - Can you please see Srushti's comment above and add that? Thanks |
Perfect, once that is done, @SrushtiPasari94 can pull this in. |
I have updated according to @SrushtiPasari94 comment, could you take a look and merge it? Thanks! |
This pr is all changes to convert eShopOnWeb application into an Azd template.
You can currently deploy the eShopOnWeb application using
azd
by following the steps below:@jongio, @rajeshkamal5050 for notification.