增加分版本的package引用和framework引用 #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zhuangkh 特别感谢你的更改，但是由于最近杂事较多，需要迟一点看哈 |
|
@Zhuangkh 有个坏消息是收集时机问题，按照本次更改的逻辑，似乎存在收集不全的情况 |
lindexi
reviewed
Nov 15, 2021
| @@ -1,5 +1,12 @@ | |||
| <Project> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Update="#(PackageId)"> | |||
There was a problem hiding this comment.
影响的点是..? 这句话解决的问题是#112
There was a problem hiding this comment.
参考 NuspecMetadata 的 DevelopmentDependency 属性
有没有可供测试的项目文件? |
|
@Zhuangkh 很抱歉，我用的是内部实际的项目去跑，相对复杂一些。我试试构建出 demo 来给你，但是没那么快能给出，十分感谢你的贡献 |
lindexi
reviewed
Nov 18, 2021
| <EmbeddedResourceTextFile>$(SourcePackingDirectory)EmbeddedResourceFile.txt</EmbeddedResourceTextFile> | ||
| <PageTextFile>$(SourcePackingDirectory)PageFile.txt</PageTextFile> | ||
| <ApplicationDefinitionTextFile>$(SourcePackingDirectory)ApplicationDefinitionFile.txt</ApplicationDefinitionTextFile> | ||
| <CompileTextFile>$(PackingDirectory)CompileFile.txt</CompileTextFile> |
There was a problem hiding this comment.
不适合采用 PackingDirectory 因为有时机要求，可能是空值
|
感谢 @Zhuangkh 我准备在你的基础上进行优化 |
|
@lindexi 不用这么客气哈,项目思路很好,解决了我一些问题😋 |
|
@Zhuangkh 我今天正在改改改，然后翻车中。原因是我的项目们正在升级到 .NET 6 上，存在一些兼容性的问题，其中一项就是 SourceYard 库的寻找逻辑，于是开始修 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.