Add ToDotGraph() method #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ internal class StateRepresentation | |||
| { | |||
| readonly TState _state; | |||
|
|
|||
| readonly IDictionary<TTrigger, ICollection<TriggerBehaviour>> _triggerBehaviours = | |||
| protected internal readonly IDictionary<TTrigger, ICollection<TriggerBehaviour>> _triggerBehaviours = | |||
There was a problem hiding this comment.
Rather than making the fields protected internal could we wrap them in internal properties?
|
Looks great, just a couple of minor comments. Is it also possible to include a README update in the PR that notes this method and links to some DOT visualisation options? Just a thought :-) Cheers! |
|
Thanks for the feedback! Please let me know if there are any remaining/new issues or if you have more good suggestions. Also, I'll gladly squash the feature branch into a single commit if your prefer that. :-) |
|
Thanks, looks great. Looks like I need to get CI for this set up :-) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for nblumhardt/stateless/issues/31