New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitelets.HttpModule should throw an error if no Sitelet definition is found #1020

Closed
Jand42 opened this Issue Sep 6, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Jand42
Member

Jand42 commented Sep 6, 2018

Now that the location of the Sitelet definition is stored in WebSharper metadata to speed up site initialization, the project containing the definition must have the WebSharper.FSharp/CSharp package reference, even it is server-side only. Missing this, Sitelet runtime finds nothing to run and currently the Sitelets.HttpModule just installs an empty Sitelet: a handler that handles nothing.

This causes projects to break silently when updating from WS 4.2 or lower.

Throwing an error instead of defaulting to empty Sitelet would be better. If a project does not use Sitelets, it should not set the Sitelets.HttpModule handler in web.config / ASP.NET Core startup.

@Jand42 Jand42 closed this in 364380b Sep 12, 2018

@Tarmil Tarmil added the 4.5.2.309 label Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment