Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service process to speed up repeated compilations - F# #1131

Closed
Jand42 opened this issue Jun 8, 2021 · 4 comments
Closed

Service process to speed up repeated compilations - F# #1131

Jand42 opened this issue Jun 8, 2021 · 4 comments
Assignees
@mrtank
Labels
5.0.0.50-preview1 enhancement websharper5
Projects
Releases

Comments

@Jand42
Copy link
Member

Jand42 commented Jun 8, 2021

First, on the F# side

  • Parametrize compileMain to take a factory function for F# checker from the outside.
  • New project wsfscservice.exe will run next to wsfsc.exe but can serve as a persistent background process, that takes compile arguments through a pipe, runs compileMain itself, returns standard/error outputs and exit code (depends on Compiler refactor - parametrize info/error/warning printers #1130).
  • Build script: add a step before Clean to kill any running wsfscservice from build folder before wiping the build folder.
  • Optional: add new wsconfig.json bool parameter: incrementalBuild. Default true uses wsfscservice, setting it to false runs compileMain directly.
mrtank added a commit to mrtank/core that referenced this issue Jun 9, 2021
@mrtank
Change to checkerFactory (dotnet-websharper#1131)
ae96bcd
Jand42 added a commit that referenced this issue Jun 9, 2021
@mrtank @Jand42
LoggerBase parametrization #1130 (#1132)
a905df3 
* Implementing #1130. LoggerBase class for parametrizing output in FSharp compilation.

* cleanups

* remove TODO comment

* Change to checkerFactory (#1131)

* no separate module for LoggerBase

* Add TryGetMetadata on the CSharp branch

* Fix TryGetMetadata not passing. Remove LoggerBase opens.

* Move Compile of CSharp branch into WebSharper.Compiler.CSharp

* small cleanup in main

Co-authored-by: András Jankó <andras.janko@gmail.com>
mrtank added a commit to mrtank/core that referenced this issue Jun 9, 2021
@mrtank
Add projects for the WsFscService. dotnet-websharper#1131
47356bd
mrtank added a commit to mrtank/core that referenced this issue Jun 10, 2021
@mrtank
Implement dotnet-websharper#1131 server side
d19e1d0
mrtank added a commit to mrtank/core that referenced this issue Jun 10, 2021
@mrtank
Implementing dotnet-websharper#1131 's server side
049c840
mrtank added a commit to mrtank/core that referenced this issue Jun 10, 2021
@mrtank
Insert Stopping runnig wsfscservices in the pipeline. Add client for …
60153a1 
…starting the compilation through the service dotnet-websharper#1131
mrtank added a commit to mrtank/core that referenced this issue Jul 5, 2021
@mrtank
Implementing dotnet-websharper#1131 's server side
82ef6ed 
    pick 049c840 Implementing dotnet-websharper#1131 's server side
    pick 60153a1 Insert Stopping runnig wsfscservices in the pipeline. Add client for starting the compilation through the service dotnet-websharper#1131
    pick ce27518 Fix release version compiler compile.

    pick 094c8022 Implementing dotnet-websharper#1131 's server side
    pick f0dc2fe8 Insert Stopping runnig wsfscservices in the pipeline. Add client for starting the compilation through the service dotnet-websharper#1131
    pick 3b792d0f publish service, rename project
mrtank added a commit to mrtank/core that referenced this issue Jul 5, 2021
@mrtank
Insert Stopping runnig wsfscservices in the pipeline. Add client for …
9f5e66b 
…starting the compilation through the service dotnet-websharper#1131

    pick 049c840 Implementing dotnet-websharper#1131 's server side
    pick 60153a1 Insert Stopping runnig wsfscservices in the pipeline. Add client for starting the compilation through the service dotnet-websharper#1131
    pick ce27518 Fix release version compiler compile.
    pick 7b728f8 publish service, rename project

    pick 094c8022 Implementing dotnet-websharper#1131 's server side
    pick f0dc2fe8 Insert Stopping runnig wsfscservices in the pipeline. Add client for starting the compilation through the service dotnet-websharper#1131
    pick 3b792d0f publish service, rename project
    pick 3ac742ed Add event listeners to Process's Exit and Disposed. Letting client continue on build if any of them happens.
mrtank pushed a commit to mrtank/core that referenced this issue Jul 5, 2021
@Jand42 @mrtank
publish service, rename project
a1798aa 
    pick ce27518 Fix release version compiler compile.
    pick 7b728f8 publish service, rename project
    pick 36dae0b Fix ignore case for standalone checking.
    pick 8336fc7 IndexOf instead of String.Equals ignoring trailing widespaces

    pick f0dc2fe8 Insert Stopping runnig wsfscservices in the pipeline. Add client for starting the compilation through the service dotnet-websharper#1131
    pick 3b792d0f publish service, rename project
    pick 3ac742ed Add event listeners to Process's Exit and Disposed. Letting client continue on build if any of them happens.
    pick 9c7668d3 Add logging. Change wsfscservice_start.cmd to use start instead of dotnet. Try catch around mailboxprocessor's inner loop.
@mrtank
Copy link
Member

mrtank commented Jul 5, 2021 •
edited

WIG and sitelets+html+bundle operations should not happen in wsfscservice.exe, which need current assembly to be loaded to execute and then that version of the dll is locked in

@mrtank
Copy link
Member

mrtank commented Jul 9, 2021 •
edited by granicz

"Optional: add new wsconfig.json bool parameter: incrementalBuild. Default true uses wsfscservice, setting it to false runs compileMain directly."

This is now the --standalone flag. Default value false uses wsfscservice. Also controllable via the <WebSharperStandalone>True<WebSharperStandalone> project property, or the WebSharperBuildService environment variable = "False". Both of these disable using the wsfscservice.

@Jand42
Copy link
Member Author

Jand42 commented Jul 16, 2021

As part of this, compiler service needs to use an AssemblyLoadContext whenever instantiating types from compiled project or it's dependencies.
These usages are:

  • WS compilation: macros, generators
  • Unpack website resources: only for DownloadResources e292d9a
  • Html offline site: main functionality for instantiating IWebSite/Sitelet object e292d9a
  • Bundling, including webworker bundles: for resource instances 1cf8aae
  • WIG: main functionality, for instantiating Assembly definition

Jand42 added a commit that referenced this issue Jul 16, 2021
@Jand42
#1131 use ALC for bundling for C# too
1421625
Jand42 added a commit that referenced this issue Jul 16, 2021
@Jand42
#1131 debug mode logging and further fixes+cleanup around AssemblyLoa…
ac7d187 
…dContext
@granicz granicz added this to v5.0-preview in Releases Jul 22, 2021
@Jand42
Copy link
Member Author

Jand42 commented Jul 23, 2021

Service is implemented for WebSharper 5.0-preview builds, create new ticket for the ws helper #1166

@Jand42 Jand42 closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrtank mrtank

Labels
5.0.0.50-preview1 enhancement websharper5
Projects
Releases
v5.0
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrtank @Jand42