Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript attribute for constructor parameters #1267

Closed
Jand42 opened this issue Oct 3, 2022 · 1 comment
Closed

JavaScript attribute for constructor parameters #1267

Jand42 opened this issue Oct 3, 2022 · 1 comment
Labels
6.0.3.237 enhancement

Comments

@Jand42
Copy link
Member

Jand42 commented Oct 3, 2022

WebSharper already has a feature to add a JavaScript attribute next to ReflectedDefinition, to pre-compile expressions client-side passed into the method. For example this is used internally by WebSharper.UI's client (myClientSideDoc(capturedVar)).

Enable this feature for constructors too, ideally without breaking change in metadata format.
Jooseppi12 added a commit that referenced this issue Oct 3, 2022
@Jooseppi12
#1266 #1267 : JavaScript attribute for constructor parameter, remove …
68b75cf 
…InlineControl.Create and use constructor instead
Jand42 pushed a commit that referenced this issue Oct 3, 2022
@Jooseppi12
#1266 #1267 JavaScript attribute for constructor parameter
bf9ee13 
remove InlineControl.Create and use constructor instead
@Jand42
Copy link
Member Author

Jand42 commented Oct 3, 2022

Passing.

@Jand42 Jand42 closed this as completed Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.0.3.237 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jand42