Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trialing GraphBasedChecking with latest FCS #1329

Closed
TheAngryByrd opened this issue Apr 20, 2023 · 5 comments
Closed

Trialing GraphBasedChecking with latest FCS #1329

TheAngryByrd opened this issue Apr 20, 2023 · 5 comments

Comments

@TheAngryByrd
Copy link

👋 I'm trying out some of the new GraphBasedChecking in the F# compiler. It's available currently in the 7.0.4xxx preview bits. The way to enable it is via OtherFlags such as:

<OtherFlags>$(OtherFlags) --test:GraphBasedChecking</OtherFlags>

However, the websharper task fails with this extra argument.

WEBSHARPERTASK : warning FS1063: Unknown --test argument: 'GraphBasedChecking' 
C:\Users\jimmy\.nuget\packages\websharper.fsharp\6.1.4.277\build\WebSharper.FSharp.targets(50,5): error MSB6006: "wsfsc.exe" exited with code 1. 

I did a verbose build with dotnet build -v d but I wasn't able to get a stacktrace or anything else that was useful.

@granicz
Copy link
Member

granicz commented Apr 20, 2023

Yeah, we need to update to the latest FCS and we need to enable passing the new argument. @Jand42 Can we update FCS in the next build (on this or a new ticket)?

@Jand42
Copy link
Member

Jand42 commented Apr 21, 2023

@TheAngryByrd @granicz Yes, I can make a new internal (github packages only for now) build with latest preview FCS, I'm tagging changes with this ticket.

Jand42 added a commit that referenced this issue Apr 21, 2023
@Jand42
Copy link
Member

Jand42 commented Apr 21, 2023

@TheAngryByrd Build is 6.1.5.290

@TheAngryByrd
Copy link
Author

Seems to not fail anymore! Thanks for jumping on it so quick. Ya'll are awesome :)

Feel free to close this if that's the workflow.

@Jand42
Copy link
Member

Jand42 commented Apr 22, 2023

@TheAngryByrd Thanks, but I'll leave this open until there is a stable FCS build containing this flag then I can push out packages to nuget.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants