Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow name collision on interfaces with Stub #1395

Closed
Jooseppi12 opened this issue Feb 19, 2024 · 1 comment
Closed

Allow name collision on interfaces with Stub #1395

Jooseppi12 opened this issue Feb 19, 2024 · 1 comment

Comments

@Jooseppi12
Copy link
Member

Consider the following interface:

type MyType =
    abstract MyFunc : string -> string
    abstract MyFunc : string seq -> string

The resulting JS should not rename MyFunc to MyFunc_1 to avoid name collision, as we are using this for interop purposes

@Jand42 Jand42 changed the title Allow name collision on interfaces when stubInterfaces is true Allow name collision on interfaces with Stub Feb 19, 2024
@Jand42
Copy link
Member

Jand42 commented Feb 19, 2024

Modified ticket name: implementing this change for all Stubs, using the stubInterfaces=true setting is just a special case

Jand42 added a commit that referenced this issue Feb 19, 2024
@granicz granicz added this to v7.0 in Releases Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants