New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singleton value for argumentless union cases #696
Comments
Optional:
|
Jand42
added a commit
that referenced
this issue
May 25, 2017
Jand42
added a commit
that referenced
this issue
May 25, 2017
Jand42
added a commit
that referenced
this issue
May 25, 2017
A regression: unions with no prototype and a singleton case will have an Address on their metadata, to look up singleton values. Type checks against the union (for example using it in an erased union) will mistakenly think the address is also a valid prototype to check against, ignoring HasWsPrototype |
Jand42
added a commit
that referenced
this issue
May 26, 2017
Jand42
added a commit
that referenced
this issue
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently WS creates a new object on each union case construction, whereas in .NET argumentless union cases use a single static instance. This should follow .NET semantics closer for performance.
The text was updated successfully, but these errors were encountered: