Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added decimal overload for MathJS.Math.Round #1305

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Added decimal overload for MathJS.Math.Round #1305

merged 1 commit into from
Jan 2, 2023

Conversation

diegopego
Copy link
Contributor

No description provided.

@Jand42
Copy link
Member

Jand42 commented Jan 2, 2023

Thanks!

@Jand42 Jand42 merged commit c84b153 into dotnet-websharper:master Jan 2, 2023
@diegopego
Copy link
Contributor Author

András, System.Math.Round takes an int as decimals argument. Math.JS should it use int too? Right now it is using decimal.

Math.Round(d: decimal, decimals: int) : decimal
Math.Round(a: decimal, b: decimal) : decimal

@diegopego diegopego deleted the diegopego-MathJs-Round-decimal-overload branch January 5, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.1.2.265
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diegopego @Jand42 @Jooseppi12