New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New article for Blazor CSS isolation #19956
Conversation
We haven't forgotten about this @daveabrock ... we should be getting to it very soon. |
@javiercn and @guardrex - updated the docs based on @javiercn and @meziantou feedback. If that is all good, @guardrex might be able to take a look now... |
I'll wait for @javiercn to sign off first ... then make a pass and ping u for a final look. |
@captainsafia ... Can you perform the technical review and then I'll round up the UE updates? |
Co-authored-by: Safia Abdalla <safia@safia.rocks>
Pushed changes based on recent feedback (thanks @captainsafia). cc @guardrex |
Cool ... I'll make an edit pass asap, but it might be early next week. I'm 🏃🏃🏃😅 on Blazor security work at the moment. |
@daveabrock @guardrex FYI - there are various changes coming to CSS isolation in .NET 5 RC2 that we'll need to react to in this doc: dotnet/aspnetcore#25565 |
@daveabrock ... I'll hold off on my pass until you get a chance to react; or if you're too busy for the updates, I'll take a shot at getting them into the doc. |
I can take a look at these. I'll do some updates this weekend, then test the updates when RC2 comes out. Which I'm sure is very soon. 😁 |
With RC2 out now, @guardrex, should have updates in tonight and updates ready for review tomorrow AM. |
Sure thing ... no worries ... we're still fine here. We target to make sure that docs are up by release at the latest, then we go for preview when we're able. I certainly wouldn't rush you on updates given that you're putting in your time and effort on this. It's great to have your help. I'm still getting the last of the .NET Blazor WASM security updates in, so you've taken a real burden off of me so that I can focus on these security updates. If you even need a little more time, don't sweat it ... take the time. We still have a few weeks left to go. |
OK, @guardrex, I pushed updates for RC2. I created a Razor Class Library in the sample app to understand the changes and how projects are referenced—slick! A subtle change is in the first note, I added the "Razor" word: I clarified this because the generated bundles use CSS imports but this is still not allowed: @css { } Adding "Razor" to the note probably avoids further confusion. |
Thanks @daveabrock ... I'll be free I think on ...... errrrrrr 🤔 ..... Monday late morning. My Friday is already full, and I have a priority WASM hosting regression to address Monday morning. |
@guardrex - sounds great! (The review, not the regression. 😉) |
@daveabrock ... Almost here! 🏃😅 It only took TEN hours today to get my hosted WASM with AAD groups and roles security code running. Yikes! 😄 Well .... at least it IS running! 🎉🍻 This PR is coming up next. I reached a 🧠🔥 brain fry 🧠🔥 about an hour ago (and I need to get the Blazor 5.0 bits into the What's New for 5.0 topic tonight), so I won't get to this by EOD. Hopefully, I'll reach this by tomorrow (Tuesday). |
Thoughts and prayers. I really appreciate you keeping me up to date! |
Sure thing. I don't think they'll be much more for you to do. I'll make a direct edit pass that will probably consist of nit updates for our style guidelines. I'll ping you to review the updates, then we'll ask the product unit if it's ok to get this content merged. |
Great job ... I ❤️ the doc! You might (er ... likely will) need to edit my changes a bit. I may have 💥:cry: a bit of meaning that you'll need to correct. Notes on my changes:
If you find that you're getting too many pings from being in the After you fix 🙈 any of my edits that went sideways, we'll see about wrapping this up and getting it merged. |
Actually, I went through this when I was emailed about your push and I think it looks good, and you haven't lost any meaning with your changes. With this and my blog post being the top search result for this topic, for better or worse I am the "Blazor CSS isolation guy" so I may as well embrace it! We can leave my name on, and I'll ping you if it gets to be a little too much. |
"I may as well embrace it!" ..... put that on my tombstone please. ⚰️ lol If you end up with too many pings and having to deal with too many dev support requests, just send a PR changing the @captainsafia ... Do you want to take a final look and then I can merge this, or do you want to call for additional product unit review before merging? I suspect that all of the GA coverage will be reviewed in the live preview topics in the days leading up to release or very soon thereafter, so I think we can go ahead and merge this. |
|
||
In the preceding example, the CSS generated for `MyComponent.Razor.css` changes its scope identifier from `b-<10-character-string>` to `my-custom-scope-identifier`. | ||
|
||
### Change base path for static web assets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right place to include this heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's no natural way unless we include it in the main section where it's discussed. I personally wanted to save the config to the end as it is optional and probably rarely used.
Co-authored-by: Safia Abdalla <safia@safia.rocks>
btw @daveabrock ... For that Line 24 change ... "along side" 👉 "alongside" (one word) |
🚢?!?!?! |
We'll wait for @captainsafia to give a final okey-dokey and say if we should call anyone else in. Personally, I think it's good to go. We can have additional 👀 anytime up to and just after 5.0 GA on the live topic for last minute nits. |
I'll do a pass on this tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thank U so much @daveabrock for taking this on. Your topic contribution is 🥇 greatly appreciated! 🙇♂️. After merging this PR, I'll do a live docs update, so this should be online shortly in the preview docs. |
Still cannot locate sections about minification. |
There's nothing built-in for that, @voroninp. You can use any 3rd party thing that you like. Check with the community on it for ideas on what folks are using ...
|
Here's the new article on Blazor CSS isolation. I'm looking forward to your feedback.
I struggled a little with the CSS preprocessor section and how much in detail we should go into it. After all, CSS isolation works out of the box well, so don't want to overwhelm, but there's also a lot of folks that are interested in this.
cc @guardrex @javiercn
Fixes #19360