Blazor WASM debugging profile #23564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You're right, the latter is better. Based on chromium documentation, it's just a "profile" that we use as a dev profile.
Will everyone know this means Edge/Chrome? Not sure how well known the term may or may not be. |
TanayParikh
reviewed
Oct 20, 2021
|
@TanayParikh ... Try the diff now with the latest updates and see how it looks/works. |
TanayParikh
approved these changes
Oct 20, 2021
TanayParikh
suggested changes
Oct 20, 2021
There was a problem hiding this comment.
see how it looks/works
Missed the works part, I'll try it out today.
Sorry about the confusion @guardrex!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23561
Thanks @anurse! ... and 👋 ... and plz let me know ur feedback on this (at least temporary) coverage. Very minor point: Since I go with a cross-link to the PU issue for details, you could make the title of the PU issue use "a Chromium-based browser" instead of "Edge" ... it would be a little better that way if Safia decides that we only ever need to cross-link the PU issue here and never host specific doc guidance on this (i.e., the steps for setting up the custom browser launch) 👇.
Safia, there are some scattered bits of guidance in VS docs for setting up VS for running with a profile, but nothing as specific and helpful as the PU issue. For now, I think we should direct readers there for the detailed steps. We could eventually carry the guidance in the topic.
Do you agree with cross-linking the PU issue for now?
Would you like the topic to eventually ... later ... much later 🏃😅, i.e., middle of next year ... would you like the topic carry the exact guidance and drop the PU issue cross-link? If so, I'll open a follow-up issue of low priority for it after we merge this.
On a specific point here: Is it actually named
dev-profile? ... or instead of saying ...... should that read ...