Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deadlinks in aspnetcore section of repo #4241

Merged
merged 56 commits into from
Sep 12, 2017
Merged

Remove Deadlinks in aspnetcore section of repo #4241

merged 56 commits into from
Sep 12, 2017

Conversation

isaacrlevin
Copy link
Contributor

@isaacrlevin isaacrlevin commented Sep 8, 2017

This PR partially resolves Issue #3593 to fix any Invalid External Links in the Current Repo. The target of this particular PR is just for the aspnetcore section of the repo. Here is what is included in this PR

  • All links with Status Code of 3xx are changed to be the end location of the Redirect
  • All links wth 4xx or 5xx are changed to point to correct locations or removed (this was done by looking at all links with this issue and going to the url and researching what the url would be)
  • All MISC items (PDFs, linked code samples not embedded, images) are resolved as well.

There were about files that are updated here. If it needs to be split up into separate sections I can do that. Also not sure what the plan should be with aspnet folder as there are some links that reference very outdated technology (VS 2013 for instance) and some pages may need substantial rewrite.

Let me know @Rick-Anderson


* Used to handle requests with a given file name or extension, such as *.report*

* [Configured](https://msdn.microsoft.com/library/46c5ddfy.aspx) in *Web.config*
* [Configured](https://docs.microsoft.com/en-us/iis/configuration/system.webserver/handlers/) in *Web.config*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the "en-us/" segment from the URL.


* Invoked for every request

* Able to short-circuit (stop further processing of a request)

* Able to add to the HTTP response, or create their own

* [Configured](https://msdn.microsoft.com/library/ms227673.aspx) in *Web.config*
* [Configured](https://docs.microsoft.com/en-us/iis/configuration/system.webserver/modules/) in *Web.config*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en-us"

@@ -133,4 +133,4 @@ Adding your provider to the end of the collection may result in a built-in model
Custom model binders:
- Should not attempt to set status codes or return results (for example, 404 Not Found). If model binding fails, an [action filter](xref:mvc/controllers/filters) or logic within the action method itself should handle the failure.
- Are most useful for eliminating repetitive code and cross-cutting concerns from action methods.
- Typically should not be used to convert a string into a custom type, a [`TypeConverter`](https://msdn.microsoft.com/library/ayybcxe5.aspx) is usually a better option.
- Typically should not be used to convert a string into a custom type, a [`TypeConverter`](https://docs.microsoft.com/en-us/dotnet/api/system.componentmodel.typeconverter) is usually a better option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en-us"

@@ -63,7 +63,7 @@ Registered users of your web site. The [IdentityUser](https://docs.microsoft.com

### User Claims

A set of statements (or [claims](https://msdn.microsoft.com/library/system.security.claims.claim(v=vs.110).aspx)) about the user that represent the user's identity. Can enable greater expression of the user's identity than can be achieved through roles.
A set of statements (or [Claims](https://docs.microsoft.com/en-us/dotnet/api/system.security.claims.claim) about the user that represent the user's identity. Can enable greater expression of the user's identity than can be achieved through roles.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en-us"

@@ -18,7 +18,7 @@ Note: This topic applies to ASP.NET Core 2.x with Razor Pages.

ASP.NET Core ships with support for authenticator applications for individual authentication. Two factor authentication (2FA) authenticator apps, using a Time-based One-time Password Algorithm (TOTP), are the industry recommended approch for 2FA. 2FA using TOTP is preferred to SMS 2FA. An authenticator app provides a 6 to 8 digit code which users must enter after confirming their username and password. Typically an authenticator app is installed on a smart phone.

The ASP.NET Core web app templates support authenticators, but do not provide support for QRCode generation. QRCode generators ease the setup of 2FA. This document will guide you through adding [QR Code](https://wikipedia.org/wiki/QR_code) generation to the 2FA configuration page.
The ASP.NET Core web app templates support authenticators, but do not provide support for QRCode generation. QRCode generators ease the setup of 2FA. This document will guide you through adding [QR Code](https://en.wikipedia.org/wiki/QR_code) generation to the 2FA configuration page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en."

@@ -20,13 +20,13 @@ In this section validation logic is added to the `Movie` model. The validation r

## Validation

A key tenet of software development is called [DRY](http://en.wikipedia.org/wiki/Don%27t_repeat_yourself) ("**D**on't **R**epeat **Y**ourself"). Razor Pages encourages development where functionality is specified once, and it's reflected throughout the app. DRY can help reduce the amount of code in an app. DRY makes the code less error prone, and easier to test and maintain.
A key tenet of software development is called [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) ("**D**on't **R**epeat **Y**ourself"). Razor Pages encourages development where functionality is specified once, and it's reflected throughout the app. DRY can help reduce the amount of code in an app. DRY makes the code less error prone, and easier to test and maintain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en."


**Note:** The [Contains](http://msdn.microsoft.com/library/bb155125.aspx) method is run on the database, not in the C# code. The case sensitivity on the query depends on the database and the collation. On SQL Server, `Contains` maps to [SQL LIKE](https://docs.microsoft.com/en-us/sql/t-sql/language-elements/like-transact-sql), which is case insensitive. In SQLite, with the default collation, it's case sensitive.
**Note:** The [Contains](https://docs.microsoft.com/en-us/dotnet/api/system.data.objects.dataclasses.entitycollection-1.contains) method is run on the database, not in the C# code. The case sensitivity on the query depends on the database and the collation. On SQL Server, `Contains` maps to [SQL LIKE](https://docs.microsoft.com/sql/t-sql/language-elements/like-transact-sql), which is case insensitive. In SQLite, with the default collation, it's case sensitive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en-us"

@@ -37,7 +37,7 @@ Select `using System.ComponentModel.DataAnnotations;`

Visual studio adds `using System.ComponentModel.DataAnnotations;`.

We'll cover [DataAnnotations](http://msdn.microsoft.com/library/system.componentmodel.dataannotations.aspx) in the next tutorial. The [Display](https://msdn.microsoft.com/library/system.componentmodel.dataannotations.displayattribute.aspx) attribute specifies what to display for the name of a field (in this case "Release Date" instead of "ReleaseDate"). The [DataType](https://msdn.microsoft.com/library/system.componentmodel.dataannotations.datatypeattribute.aspx) attribute specifies the type of the data (Date), so the time information stored in the field is not displayed.
We'll cover [DataAnnotations](https://docs.microsoft.com/aspnet/mvc/overview/older-versions/mvc-music-store/mvc-music-store-part-6) in the next tutorial. The [Display](https://docs.microsoft.com/en-us/aspnet/core/api/microsoft.aspnetcore.mvc.modelbinding.metadata.displaymetadata) attribute specifies what to display for the name of a field (in this case "Release Date" instead of "ReleaseDate"). The [DataType](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.mvc.dataannotations.internal.datatypeattributeadapter) attribute specifies the type of the data (Date), so the time information stored in the field is not displayed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en-us"

#### [Integrating Azure AD Into an ASP.NET Core Web App](https://azure.microsoft.com/documentation/samples/active-directory-dotnet-webapp-openidconnect-aspnetcore/)
#### [Calling a ASP.NET Core Web API From a WPF Application Using Azure AD](https://azure.microsoft.com/documentation/samples/active-directory-dotnet-native-aspnetcore/)
#### [Calling a Web API in an ASP.NET Core Web Application Using Azure AD](https://azure.microsoft.com/documentation/samples/active-directory-dotnet-webapp-webapi-openidconnect-aspnetcore/)
### [Securing ASP.NET Core apps with IdentityServer4](https://identityserver4.readthedocs.io/en/release/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en/"

* [An ASP.NET Core web app with Azure AD B2C](https://azure.microsoft.com/documentation/samples/active-directory-dotnet-webapp-openidconnect-aspnetcore-b2c/)
* [Securing ASP.NET Core apps with IdentityServer4](https://identityserver4.readthedocs.io)
* [An ASP.NET Core web app with Azure AD B2C](https://azure.microsoft.com/resources/samples/active-directory-b2c-dotnetcore-webapp/)
* [Securing ASP.NET Core apps with IdentityServer4](https://identityserver4.readthedocs.io/en/release/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en/"

@@ -18,7 +18,7 @@ By [Mike Wasson](https://github.com/mikewasson), [Shayne Boyer](https://twitter.

Browser security prevents a web page from making AJAX requests to another domain. This restriction is called the *same-origin policy*, and prevents a malicious site from reading sensitive data from another site. However, sometimes you might want to let other sites make cross-origin requests to your web API.

[Cross Origin Resource Sharing](http://www.w3.org/TR/cors/) (CORS) is a W3C standard that allows a server to relax the same-origin policy. Using CORS, a server can explicitly allow some cross-origin requests while rejecting others. CORS is safer and more flexible than earlier techniques such as [JSONP](http://en.wikipedia.org/wiki/JSONP). This topic shows how to enable CORS in an ASP.NET Core application.
[Cross Origin Resource Sharing](http://www.w3.org/TR/cors/) (CORS) is a W3C standard that allows a server to relax the same-origin policy. Using CORS, a server can explicitly allow some cross-origin requests while rejecting others. CORS is safer and more flexible than earlier techniques such as [JSONP](https://en.wikipedia.org/wiki/JSONP). This topic shows how to enable CORS in an ASP.NET Core application.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en." from Wikipedia URL


* [Securing ASP.NET Core apps with IdentityServer4](https://identityserver4.readthedocs.io)
* [Securing ASP.NET Core apps with IdentityServer4](https://identityserver4.readthedocs.io/en/release/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "en/"

@scottaddie scottaddie changed the title [WIP] Remove Deadlinks in aspnetcore section of repo Remove Deadlinks in aspnetcore section of repo Sep 11, 2017
@scottaddie scottaddie closed this Sep 11, 2017
@scottaddie scottaddie reopened this Sep 11, 2017
@dnfclas
Copy link

dnfclas commented Sep 11, 2017

@isaac2004,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@scottaddie
Copy link
Member

Going to close and open once more to trigger the build.

@scottaddie scottaddie closed this Sep 12, 2017
@scottaddie scottaddie reopened this Sep 12, 2017
@dnfclas
Copy link

dnfclas commented Sep 12, 2017

@isaac2004,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@scottaddie scottaddie merged commit 854c07c into dotnet:master Sep 12, 2017
@scottaddie
Copy link
Member

@isaac2004 A big shout out to you for all the hard work on this one! Thanks again for your help.

@isaacrlevin
Copy link
Contributor Author

@scottaddie can you close the issue this PR was for. I want to check it off my list of issues I am addressing.

@scottaddie
Copy link
Member

@isaac2004 Thanks for the reminder. I've closed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants