Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ColoredLogger for LinqPad #447

Closed
AndreyAkinshin opened this issue May 11, 2017 · 3 comments
Closed

Implement ColoredLogger for LinqPad #447

AndreyAkinshin opened this issue May 11, 2017 · 3 comments
Labels
Area:Loggers enhancement
Milestone
v0.11.2

Comments

@AndreyAkinshin
Copy link
Member

Original discussion: #445 (comment)
@AndreyAkinshin AndreyAkinshin self-assigned this May 11, 2017
@AndreyAkinshin AndreyAkinshin mentioned this issue May 11, 2017
Closed
@AndreyAkinshin AndreyAkinshin removed their assignment Aug 22, 2017
@bgrainger
Copy link
Contributor

As an avid BDN and LINQPad user, I'm interested in implementing this (for Hacktoberfest). My understanding of the requirements is:

  • Add the code from the linked comment
    • Use Reflection to call Util.WithStyle to avoid taking a dependency
    • Detect LINQPad Dark Mode and use alternate colour scheme
  • Detect whether running under LINQPad (either using AppDomain.CurrentDomain.FriendlyName or assembly location)
  • Automatically add a LinqPadLogger to the default configuration if running under LINQPad? (Not sure about this)

Out-of-scope (unless easy):

  • Add a ToDump() method to dump the Summary in a formatted way

Without objection, I'll start working on this.

@AndreyAkinshin
Copy link
Member Author

Hey @bgrainger! The plan looks good to me.

bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 10, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
3f08333
@bgrainger bgrainger mentioned this issue Oct 10, 2018
Merged
bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 10, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
2079db7
bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 10, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
c50b082
bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 11, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
dcc7470
bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 11, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
37d7600
bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 11, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
8f8b709
bgrainger added a commit to bgrainger/BenchmarkDotNet that referenced this issue Oct 13, 2018
@bgrainger
Add LINQPad logging. Fixes dotnet#447
ec8da6e
AndreyAkinshin pushed a commit that referenced this issue Oct 14, 2018
@bgrainger @AndreyAkinshin
Add LINQPad logging (#903)
c3b6095 
Adds a logger that sends coloured output to LINQPad, fixing #447.

This new logger is enabled by default (in `DefaultConfig`) if the benchmark detects that it's being run under LINQPad. This makes it really easy to use, but I wasn't sure if this "magic" was appropriate; let me know if you'd like it to be done a different way.
@bgrainger
Copy link
Contributor

#903 implemented LinqPadLogger; this issue should now be closed.

@AndreyAkinshin AndreyAkinshin added this to the v0.11.2 milestone Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area:Loggers enhancement
Projects
None yet
Milestone
v0.11.2
Development

No branches or pull requests
2 participants
@bgrainger @AndreyAkinshin