Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Using System.CommandLine #1037

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

WojciechNagorski
Copy link
Contributor

Please do not merge yet.

PR for #1016

@WojciechNagorski WojciechNagorski changed the title [WIP] Using System.CommandLine Using System.CommandLine Apr 5, 2019
@AndreyAkinshin
Copy link
Member

@wojtpl2 what the status of this PR?

@adamsitnik
Copy link
Member

what the status of this PR?

System.CommandLine* packages are still uploaded to NuGet.org as previews.

@AndreyAkinshin can we upload a new stable version of BDN with a preview dependency to nuget.org?

@WojciechNagorski WojciechNagorski changed the title Using System.CommandLine [WIP] Using System.CommandLine Sep 9, 2019
@WojciechNagorski
Copy link
Contributor Author

@AndreyAkinshin This PR was completed for version 0.2.0-alpha. It doesn't work for new version 0.3.0-alpha.
I can update this PR for the new version of System.CommandLine and merge it with master but only if I can use preview version of this nuget package. As @adamsitnik asked:

@AndreyAkinshin can we upload a new stable version of BDN with a preview dependency to nuget.org?

@AndreyAkinshin
Copy link
Member

can we upload a new stable version of BDN with a preview dependency to nuget.org?

Technically, yes: we can pack and upload a stable version of a NuGet package with preview dependencies. However, it's not a good idea because NuGet still has problems with the install operation for such packages (e.g., see NuGet/Home#2944).
Thus, we have to wait until System.CommandLine is released.

@adamsitnik
Copy link
Member

@KathleenDollard @jonsequitur we would be very happy to dogfood System.CommandLine but as you can see in the thread above we can't publish anything to nuget.org that has some preview dependencies. When can we expect to have a non-preview version?

We are fine with API changes between the releases, we have a lot of unit tests that check the correctness of the parser and this is the only blocker for us.

@jonsequitur
Copy link

We do publish several release versions of global tools with dependencies on pre-release versions of System.CommandLine. Since dependencies of global tools aren't transient, this hasn't been an issue.

@WojciechNagorski
Copy link
Contributor Author

@jonsequitur BenchmarkDotNet is not only a global tool but above all a library.

Global tool package: https://www.nuget.org/packages/BenchmarkDotNet.Tool
Library package: https://www.nuget.org/packages/BenchmarkDotNet

@WojciechNagorski
Copy link
Contributor Author

System System.CommandLine is still beta - https://www.nuget.org/packages/System.CommandLine/

@WojciechNagorski WojciechNagorski marked this pull request as draft November 20, 2020 13:48
@jonsequitur
Copy link

We expect to GA in first half of the coming year.

@WojciechNagorski
Copy link
Contributor Author

System.CommandLine is still beta.

@jonsequitur
Copy link

It will be out of beta alongside .NET 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants