-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing up some infrastructure so we can consume the libclang 8.0.0 packages #65
Changes from all commits
aadb173
9a1dc15
fc69342
b1479fd
e14068f
c626d43
c5286b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,11 @@ | |
<DefineConstants>$(DefineConstants);$(OS)</DefineConstants> | ||
</PropertyGroup> | ||
|
||
<!-- Settings that allow testing to work by default --> | ||
<PropertyGroup> | ||
<RuntimeIdentifier Condition="'$(RuntimeIdentifier)' == ''">$(NETCoreSdkRuntimeIdentifier)</RuntimeIdentifier> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The libclang package is setup using a |
||
</PropertyGroup> | ||
|
||
<!-- Tool versions for tool references across all projects --> | ||
<ItemGroup> | ||
<DotNetCliToolReference Update="dotnet-xunit" Version="2.3.1" /> | ||
|
@@ -24,10 +29,10 @@ | |
<ItemGroup> | ||
<PackageReference Update="libClang" Version="5.0.0" NoWarn="NU1701" /> | ||
<PackageReference Update="Microsoft.Net.Compilers.Toolset" Version="3.2.0-beta1-final" /> | ||
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="15.6.0" /> | ||
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="16.1.1" /> | ||
<PackageReference Update="System.CommandLine.Experimental" Version="0.2.0-alpha.19174.3" /> | ||
<PackageReference Update="xunit" Version="2.3.1" /> | ||
<PackageReference Update="xunit.runner.visualstudio" Version="2.3.1" /> | ||
<PackageReference Update="xunit" Version="2.4.1" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These were a few versions old. Upgrading to get perf and other minor benefits. |
||
<PackageReference Update="xunit.runner.visualstudio" Version="2.4.1" /> | ||
</ItemGroup> | ||
|
||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to mark this as
PrivateAssets="all"
so that the product packages don't list it as a dependency.