Added labels and reference to the counters file #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
smitpatel
reviewed
Nov 2, 2021
entity-framework/core/logging-events-diagnostics/event-counters.md
Outdated
Show resolved
Hide resolved
|
Any chance this is going to get approved? Otherwise I can just abandon it. |
|
@esbenbach sorry this didn't receive any attention - it came just as the 6.0 release was being prepared. I'll review this in the coming days. |
|
/azp run |
|
No pipelines are associated with this pull request. |
roji
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added counter labels for all counters, and added a reference to the EventSource file where the counters are maintained.
The table ends up being rather "ugly" with the long counter names, so I force a line break in the counter name cell. Not sure this is the right approach for controlling the style, let me know if you want if changed.
This should solve #3234