Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on Cosmos in the owned types section #3530

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add note on Cosmos in the owned types section #3530

merged 2 commits into from
Nov 4, 2021

Conversation

roji
Copy link
Member

@roji roji commented Nov 4, 2021

Fixes #3529

@roji roji requested a review from a team November 4, 2021 14:28
JeremyLikness
JeremyLikness approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@JeremyLikness JeremyLikness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggested a possible change.

entity-framework/core/modeling/owned-entities.md Outdated Show resolved Hide resolved
@roji @JeremyLikness
Update entity-framework/core/modeling/owned-entities.md
eaf6d53 
Co-authored-by: Jeremy Likness <jeremy@jeremylikness.com>
@roji roji merged commit f87e0a3 into dotnet:main Nov 4, 2021
@roji roji deleted the CosmosOwned branch November 4, 2021 19:07
@ajcvickers ajcvickers mentioned this pull request Nov 18, 2021
Closed
@roji roji mentioned this pull request Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyLikness JeremyLikness JeremyLikness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Owned Entity Types incorrectly claims that EF Core never includes them by convention
2 participants
@roji @JeremyLikness