-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Nuget packages versions to latest #4624
base: main
Are you sure you want to change the base?
Conversation
… 0.13.12) but see caveats in my PR
apologies I temporarily "lost" reverting the "What's new in X.*" so this attempts to keep the timewarp clean (no rewriting history here!) |
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite" Version="8.0.0" /> | ||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite.NetTopologySuite" Version="8.0.0" /> | ||
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.0" /> | ||
<PackageReference Include="Microsoft.EntityFrameworkCore.Cosmos" Version="7.0.15" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is intentional that these all use the latest version. This is one of the ways we double check for breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, other than moving all What's New back to 8.
this PR relates to Issue #4611 to refresh NuGet packages to current versions
I bow to ErikEJ's push and Roji's +1 !
summary/caveats
https://benchmarkdotnet.org/articles/configs/jobs.html
"Usually, you shouldn't specify such characteristics like LaunchCount, WarmupCount, IterationCount, or IterationTime because BenchmarkDotNet has a smart algorithm to choose these values automatically based on received measurements."
so hopefully EF Team will concur that these change are apposite and will shipit
BTW I am still working on an extra PR for Issue #4612 but should arrive soon