This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Color class lacks Hue, Saturation, and Luminosity properties. #280
Labels
bug
Something isn't working
Comments
This comment has been minimized.
This comment has been minimized.
|
I implemented this suggestion in PR #281 |
swharden
added a commit
to swharden/Microsoft.Maui.Graphics
that referenced
this issue
Jan 15, 2022
Add Xamarin.Forms.Color properties to Maui.Graphics.Color (all marked obsolete): R, G, B, A, Hue, Luminosity, and Saturation dotnet#280
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Xamarin.Forms
Colorstruct hasHue,Saturation, andLuminosityproperties. The Maui.GraphicsColorclass does not. This makes the upgrade path from Forms to MAUI that more frustrating.I get that converting a
Colorto HSL every time theColorchanges isn't efficient (which is what Forms did, IIRC), when the chances are that most users aren't interested in HSL. But for anyone who did use them, well, their apps are now broken until they rewrite to call GetSaturation() etc., and restructure their code to avoid keep calling GetSaturation() etc (which recalculates the value each time) rather than just accessing a property.At the very least, I'd have hoped for
Hue,Saturation, andLuminosityproperties that are marked as obsolete for the first release. It's a bit annoying having to rewrite data binding code that bound to properties that no longer exist.The text was updated successfully, but these errors were encountered: