Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuPkg versions should include commit ID in version for more scenarios #25

Closed
AArnott opened this issue Sep 29, 2015 · 3 comments
Closed

Comments

@AArnott
Copy link
Collaborator

AArnott commented Sep 29, 2015

The current behavior is:

Stable Prerelease
PublicRelease=true 1.2.3 1.2.3-pre
PublicRelease!=true 1.2.3 1.2.3-pre-gCommit

The commit ID is not exposed frequently enough to be reliably present and useful.

The current proposal is that we leverage NuGet v3's support for +buildMetadata on the package version to enhance it to this:

Stable Prerelease
PublicRelease=true 1.2.3 1.2.3-pre
PublicRelease!=true 1.2.3+gCommit 1.2.3-pre-gCommit

Consider being even more aggressive:

Stable Prerelease
PublicRelease=true 1.2.3+gCommit 1.2.3-pre+gCommit
PublicRelease!=true 1.2.3+gCommit 1.2.3-pre-gCommit

This may need to start under an optional property that folks can control. We at least need to weigh the impact on the user experience and whether these packages can be consumed by NuGet v2.x clients.

@AArnott
Copy link
Collaborator Author

AArnott commented Sep 29, 2015

Please feel free to comment here or discuss on gitter.im.

@AArnott
Copy link
Collaborator Author

AArnott commented Sep 29, 2015

Using +buildMetadata is at least somewhat blocked by NuProj's and NuGet's lack of support for it.

@AArnott
Copy link
Collaborator Author

AArnott commented Oct 5, 2015

We really need commit IDs in more places. So the new proposal is:

Stable Prerelease
PublicRelease=true 1.2.3 1.2.3-pre
PublicRelease!=true 1.2.3-gCommit 1.2.3-pre-gCommit

@AArnott AArnott reopened this Oct 5, 2015
AArnott added a commit that referenced this issue Oct 5, 2015
Except when /p:PublicRelease=true
Fix #25
@AArnott AArnott added this to the 1.2.0 milestone Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant