Support semver-2.0+buildMetadata

[AArnott]

This doc says Nuget will support build metadata as defined by semver 2.0.0. But in NuGet 3.2 it doesn't work:

nuget pack
Attempting to build package from 'Nerdbank.GitVersioning.nuspec'.
'1.1.48-rc+gabf25bdbae' is not a valid version string.
Parameter name: version

[emgarten]

Pack is still using NuGet.Core 2.8.6 which does not support semver 2.0.0.

[emgarten]

Dupe of #1359

[AArnott]

But #1359 is already closed (as won't fix, evidently). Might this issue be considered as a request for a subset of semver-2.0? (one that can be done without all the breaking changes brought in by the rest of semver-2.0?

[emgarten]

What subset are you looking for? build metadata?

[AArnott]

Yes, per the example and issue title.

[RehanSaeed]

I'm using the latest version of nuget.exe from https://dist.nuget.org/win-x86-commandline/latest/nuget.exe and am getting the following error complaining about the version number when using the nuget publish command:

'1.0.0-1' is not a valid version string.

nuget.exe does not like the dash in the version number. There is a related issue on the ASP.NET 5 DNX GitHub repository here. I'm publishing to an internal NuGet server. Shouldn't this already be fixed?

[AArnott]

@RehanSaeed Although semver allows for the prerelease identifier to start with a digit, I suspect nuget's implementation does not. I suspect 1.0.0-a1 would work.

[RehanSaeed]

Thanks @AArnott! I believe you are correct.