Change F# AssemblyInfo generation to always include a do() after the … #1024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…version attributes
Fixes #1022
As it stands, assembly version information for F# when ThisAssembly generation is disabled generates things like
![image](https://private-user-images.githubusercontent.com/1178570/297207908-bca840ed-709a-46f4-ac4e-10646873bc7d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI1NzU3NDUsIm5iZiI6MTcyMjU3NTQ0NSwicGF0aCI6Ii8xMTc4NTcwLzI5NzIwNzkwOC1iY2E4NDBlZC03MDlhLTQ2ZjQtYWM0ZS0xMDY0Njg3M2JjN2QucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDJUMDUxMDQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWJlNWNlNjExZDE3YTg4NWYxZGJlOGFkMjdhZmIwZmNhYzI3NDJiYWQzMTE2OWYyZmFlMDhlOWE2MTMzMDU1YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.T6ptc1dbSLrfduEcGpcFlGSelxDgLADSWwTIqtwribY)
because the
do()
after the attributes is required and isn't added.There is a unit test for this case, but I don't think it's quite right as it expects the
do()
to be a header for the#if NETSTANDARD || NETFRAMEWORK || NETCOREAPP
bit instead of a footer for the assembly version attributes.