-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing to Command.Execute #1737
Conversation
Add Command.ToString (returning file name and arguments) Add Command._logger Add LogMessage to Execute (before starting) Fixes dotnet#1736
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, especially with just tracing enabled (codegen_trace=1).
After testing it, would like an additional newline added at the end of the statement ala
$"Executing external command:\n{ this }\n", LogMessageLevel.Trace
.
Also extra whitespace after LogMessageLevel
.
Thanks,
Deep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* updated package versions to GA for package dependencies (#1673) * updated package versions to GA for package dependencies * updated sdk version in global.json * reverted a couple versions * Fix spacing * Use MicrosoftGraph for appsettings * Fix scopes * revert scopes appsettings field * Update code modifier configs * [main] Update dependencies from dotnet/arcade (#1663) * Update dependencies from https://github.com/dotnet/arcade build 20211007.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21507.3 * Update dependencies from https://github.com/dotnet/arcade build 20211008.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21508.1 * Update dependencies from https://github.com/dotnet/arcade build 20211011.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21511.1 * Update dependencies from https://github.com/dotnet/arcade build 20211012.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21512.3 * Update dependencies from https://github.com/dotnet/arcade build 20211013.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21513.5 * Update dependencies from https://github.com/dotnet/arcade build 20211014.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21514.3 * Update dependencies from https://github.com/dotnet/arcade build 20211015.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21515.2 * Update dependencies from https://github.com/dotnet/arcade build 20211018.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21518.1 * Update dependencies from https://github.com/dotnet/arcade build 20211018.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21518.6 * Update dependencies from https://github.com/dotnet/arcade build 20211019.8 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21519.8 * Update dependencies from https://github.com/dotnet/arcade build 20211020.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21520.1 * Update dependencies from https://github.com/dotnet/arcade build 20211021.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21521.5 * Update dependencies from https://github.com/dotnet/arcade build 20211022.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21522.2 * Update dependencies from https://github.com/dotnet/arcade build 20211024.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21524.1 * Update dependencies from https://github.com/dotnet/arcade build 20211026.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21526.1 * Update dependencies from https://github.com/dotnet/arcade build 20211027.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21527.1 * Update dependencies from https://github.com/dotnet/arcade build 20211027.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21527.5 * Update dependencies from https://github.com/dotnet/arcade build 20211028.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21528.3 * Update dependencies from https://github.com/dotnet/arcade build 20211029.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21529.1 * updated xunit version Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: deepchoudhery <decho@microsoft.com> * Update dependencies from https://github.com/dotnet/arcade build 20211102.1 (#1681) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21529.1 -> To Version 7.0.0-beta.21552.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * removing node type check, we shouldn't care what type of node. (#1684) * Update Web API code modifier config * code change fixes for dotnet-msidentity scenarios (#1683) * code change fixes for dotnet-msidentity scenarios * minor fixes * fixed spacing in webapi msidentity config. * [main] Update dependencies from dotnet/arcade (#1690) * Update dependencies from https://github.com/dotnet/arcade build 20211103.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21552.1 -> To Version 7.0.0-beta.21553.3 * Update dependencies from https://github.com/dotnet/arcade build 20211104.4 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21552.1 -> To Version 7.0.0-beta.21554.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * fixed package dependencies when tool works with VS (#1692) * Attribute spacing fix (#1694) * fix for spacing * removed unused syntax trivia * removed MSBuild logs * removed more annoying MSBuild logs * Update dependencies from https://github.com/dotnet/arcade build 20211105.2 (#1698) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21554.4 -> To Version 7.0.0-beta.21555.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211109.3 (#1699) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21555.2 -> To Version 7.0.0-beta.21559.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/arcade (#1706) * Update dependencies from https://github.com/dotnet/arcade build 20211116.10 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21559.3 -> To Version 7.0.0-beta.21566.10 * Update dependencies from https://github.com/dotnet/arcade build 20211118.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21559.3 -> To Version 7.0.0-beta.21568.2 * Update dependencies from https://github.com/dotnet/arcade build 20211119.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21559.3 -> To Version 7.0.0-beta.21569.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/arcade (#1711) * Update dependencies from https://github.com/dotnet/arcade build 20211123.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21573.3 * Update dependencies from https://github.com/dotnet/arcade build 20211124.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21574.3 * Update dependencies from https://github.com/dotnet/arcade build 20211126.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21576.2 * Update dependencies from https://github.com/dotnet/arcade build 20211126.4 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21569.2 -> To Version 7.0.0-beta.21576.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211202.3 (#1717) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21602.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Add models from other projects [Regression] (#1718) * finding missing workspace files * using models from different projects enabled. * cleaning up more. * updated Versions.props * [main] Update dependencies from dotnet/arcade (#1720) * Update dependencies from https://github.com/dotnet/arcade build 20211203.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21602.3 -> To Version 7.0.0-beta.21603.6 * Update dependencies from https://github.com/dotnet/arcade build 20211206.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21602.3 -> To Version 7.0.0-beta.21606.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * not adding/forcing Account.Logout.cshtml if blazor project already adds it. (#1721) * Update dependencies from https://github.com/dotnet/arcade build 20211208.1 (#1722) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21606.6 -> To Version 7.0.0-beta.21608.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211209.2 (#1724) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21608.1 -> To Version 7.0.0-beta.21609.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Adding #nullable disable to scaffolding templates (#1723) * checking for nullable msbuild property and adding #nullable disable to tempaltes * added #nulalble disable logic for NewLocalDbContext * updated macOS image * fixed mistake with azure images * Update dependencies from https://github.com/dotnet/arcade build 20211210.4 (#1725) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21609.2 -> To Version 7.0.0-beta.21610.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Enable Microsoft Graph option for Blazor Server (#1719) Enable Microsoft Graph option for Blazor Server, add .razor modification functionality * Update dependencies from https://github.com/dotnet/arcade build 20211213.2 (#1740) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21610.4 -> To Version 7.0.0-beta.21613.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * fix for MsIdentity by adding Microsoft.Build assembly using Microsoft.Build.Locator (#1745) * [main] Update dependencies from dotnet/arcade (#1749) * Update dependencies from https://github.com/dotnet/arcade build 20211214.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21613.2 -> To Version 7.0.0-beta.21614.1 * Update dependencies from https://github.com/dotnet/arcade build 20211215.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21613.2 -> To Version 7.0.0-beta.21615.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211217.4 (#1759) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21615.1 -> To Version 7.0.0-beta.21617.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Add NullableEnabled to RazorPageGeneratorTemplateModel (#1755) * Add NullableEnabled to RPGeneratorTemplateModel Add NullableEnabled to RazorPageGeneratorTemplateModel Fixes #1754 * Delete RPWCTemplateModel.NullableEnabled Delete RazorPageWithContextTemplateModel.NullableEnabled * Update dependencies from https://github.com/dotnet/arcade build 20211220.2 (#1761) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21617.4 -> To Version 7.0.0-beta.21620.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [WiP] Make sure ActionInvoker throws with InnerException (#1727) * Chain caught into InvalidOperationException * ActionInvoker_Throws_With_Inner_Exception * Apply coding guidelines * use Assert.Equal * Throw ArgumentException from MsBuildProjectContextBuilder (#1732) * add message TargetLocationNotGiven * add message TargetLocationNotGiven * Throw ArgumentException in constructor * Add tests for MsBuildProjectContextBuilder * Adapt to guidelines * restore DocumentBuilderTests.cs * Create MessageStrings.resx * Create MessageStrings.Designer.cs * remove unnecessary messages * remove unnecessary messages * remove unnecessary using * fix spacing * Update dependencies from https://github.com/dotnet/arcade build 20211221.3 (#1766) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21620.2 -> To Version 7.0.0-beta.21621.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211223.1 (#1768) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21621.3 -> To Version 7.0.0-beta.21623.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20211223.2 (#1769) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.1 -> To Version 7.0.0-beta.21623.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * ScaffoldingServer: do not dispose of null members (#1763) * ScaffoldingServer: do not dispose of null members * typo fix * explicit IDisposable[] * Use ?.Dispose * OnExecute: log inner exceptions (#1751) * OnExecute: log inner exceptions Log the whole exception chain when an exception gets caught by a program. * typo fix * ActionInvoker: use chained exceptions * CodeGenCommand.Execute: log inner exceptions * Include projectReferenceString in exception (#1750) * Include projectReferenceString in exception RoslynWorkspaceHelper.GetProjectReferenceInformation: when new Project throws an exception, wrap it with InvalidOperationException holding the projectReferenceString. * using System; * [main] Update dependencies from dotnet/arcade (#1771) * Update dependencies from https://github.com/dotnet/arcade build 20211227.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.2 -> To Version 7.0.0-beta.21627.1 * Update dependencies from https://github.com/dotnet/arcade build 20211228.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.2 -> To Version 7.0.0-beta.21628.1 * Update dependencies from https://github.com/dotnet/arcade build 20211229.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.2 -> To Version 7.0.0-beta.21629.1 * Update dependencies from https://github.com/dotnet/arcade build 20211230.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.2 -> To Version 7.0.0-beta.21630.1 * Update dependencies from https://github.com/dotnet/arcade build 20220103.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.2 -> To Version 7.0.0-beta.22053.2 * Update dependencies from https://github.com/dotnet/arcade build 20220104.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21623.2 -> To Version 7.0.0-beta.22054.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Code updates for blazor server Downstream API option (#1767) * Add blazor server, and some code refactors * updating System package versions due to security vulnerabilities (#1781) * updating System package versions due to security vulnerabilities * revert package version for test. * potential fix? * fixed all compliance issues. * clean up * Update dependencies from https://github.com/dotnet/arcade build 20220106.6 (#1786) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22054.5 -> To Version 7.0.0-beta.22056.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Refactor ProjectModifier and remove calls to Directory.EnumerateFiles (#1782) * Removing EnumerateDirectories, other refactors * Update dependencies from https://github.com/dotnet/arcade build 20220113.1 (#1794) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22056.6 -> To Version 7.0.0-beta.22063.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Create and Update Blazor Wasm App Registrations (#1793) * scripts and gitignore * Update redirect uris * create and update Blazor Wasm apps * Process callback paths for remote URIs * Add comments and refactor for better readability * String updates * Fix updating bug, update strings * Update dependencies from https://github.com/dotnet/arcade build 20220113.6 (#1797) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22063.1 -> To Version 7.0.0-beta.22063.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Blazor Server: Code updates for Microsoft Graph and Downstream API options (#1798) Adding code updates for blazor server non-auth templates * only changed version to 7.0, no package/dependecy updates (#1804) * [main] Update dependencies from dotnet/arcade (#1799) * Update dependencies from https://github.com/dotnet/arcade build 20220114.25 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22063.6 -> To Version 7.0.0-beta.22064.25 * Update dependencies from https://github.com/dotnet/arcade build 20220117.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22063.6 -> To Version 7.0.0-beta.22067.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/arcade (#1807) * Update dependencies from https://github.com/dotnet/arcade build 20220118.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22067.1 -> To Version 7.0.0-beta.22068.3 * Update dependencies from https://github.com/dotnet/arcade build 20220121.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22067.1 -> To Version 7.0.0-beta.22071.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/arcade (#1810) * Update dependencies from https://github.com/dotnet/arcade build 20220124.13 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22071.6 -> To Version 7.0.0-beta.22074.13 * Update dependencies from https://github.com/dotnet/arcade build 20220125.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22071.6 -> To Version 7.0.0-beta.22075.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220126.9 (#1811) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22075.6 -> To Version 7.0.0-beta.22076.9 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Blazor Wasm: Code Updates and AppSettings updates (#1805) * Blazor Wasm: Code Updates and AppSettings updates * App Settings and Code Modification updates * App Settings and Code Modification updates * App Settings and Code Modification updates * App Settings and Code Modification updates * Update AzureAdProperties logic Address PR comments Refactor tests * Update version to 1.0.2, add reference to Nuget package * Refactor projectDescriptionReader logic * Downstream API fixes * Add AppSettings modification to CodeUpdate option * Update dependencies from https://github.com/dotnet/arcade build 20220127.8 (#1812) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22076.9 -> To Version 7.0.0-beta.22077.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * code generator: GetTargetsLocation: throw if not found (#1734) * add message TargetDirectoryNotFound * add message TargetDirectoryNotFound * GetTargetsLocation: throw if not found Throws a DirectoryNotFoundException if the build directory is not found. Fixes #1733. * Add tracing to Command.Execute (#1737) * Add tracing to Command.Execute Add Command.ToString (returning file name and arguments) Add Command._logger Add LogMessage to Execute (before starting) Fixes #1736 * Really add _logger * static readonly ConsoleLogger * minor tweaks as requested * [main] Update dependencies from dotnet/arcade (#1813) * Update dependencies from https://github.com/dotnet/arcade build 20220128.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22077.8 -> To Version 7.0.0-beta.22078.2 * Update dependencies from https://github.com/dotnet/arcade build 20220130.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22077.8 -> To Version 7.0.0-beta.22080.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * CodeGeneratorActionsService: trace template (#1756) * CodeGeneratorActionsService: trace template 1. Trace reading a template file by CodeGeneratorActionsService. 2. Add a static logger. * minor tweaks as requested * not throwing exception on invalid bootstrap versions. (#1814) * not throwing exception on invalid bootstrap . * minor fix * Update dependencies from https://github.com/dotnet/arcade build 20220203.1 (#1815) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22080.1 -> To Version 7.0.0-beta.22103.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * bump on both preview versions. (#1817) * Update Account.Manage.EnableAuthenticator.cs.cshtml (#1819) LGTM * Revert "OnExecute: log inner exceptions (#1751)" (#1821) This reverts commit 7482cf1. * Avoid building OSX/Linux in official (#1822) - These builds do not contribute to the official build outputs - These jobs are still run in PRs and rolling public CI - This avoids having to use 1ES pools in these cases * Update dependencies from https://github.com/dotnet/arcade build 20220208.1 (#1824) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22103.1 -> To Version 7.0.0-beta.22108.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220209.1 (#1825) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22108.1 -> To Version 7.0.0-beta.22109.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220210.7 (#1827) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22109.1 -> To Version 7.0.0-beta.22110.7 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220211.10 (#1828) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22110.7 -> To Version 7.0.0-beta.22111.10 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * throwing new mysql exception mssg with no sensitive information. (#1823) * throwing new mysql exception mssg with no sensitive information. * PR Fixes 1 * Update dependencies from https://github.com/dotnet/arcade build 20220214.7 (#1829) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22111.10 -> To Version 7.0.0-beta.22114.7 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * initial 7.0-preview1 + minor indent fix (#1826) * initial 7.0-preview1 + minor indent fix * updating ShortTfmDictionary for net7.0 * adding InvalidIOperationException if Configuration.GetConnectionString returns null (#1830) * Update dependencies from https://github.com/dotnet/arcade build 20220217.2 (#1834) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22114.7 -> To Version 7.0.0-beta.22117.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220222.3 (#1836) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22117.2 -> To Version 7.0.0-beta.22122.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220223.1 (#1837) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22122.3 -> To Version 7.0.0-beta.22123.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220224.1 (#1843) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22123.1 -> To Version 7.0.0-beta.22124.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Combine logic for modifying class methods and global methods, update Web API code modifier configs (#1833) * Minimal api changes * minimal api web api no controllers changes * fix web api * modify lambda logic * Formatting updates * Update README.md * Refactors * fix API templates * PR comments * revert * Update dependencies from https://github.com/dotnet/arcade build 20220224.4 (#1844) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22124.1 -> To Version 7.0.0-beta.22124.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from dotnet/arcade (#1846) * Update dependencies from https://github.com/dotnet/arcade build 20220301.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22124.4 -> To Version 7.0.0-beta.22151.1 * Update dependencies from https://github.com/dotnet/arcade build 20220302.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22124.4 -> To Version 7.0.0-beta.22152.1 * Update dependencies from https://github.com/dotnet/arcade build 20220303.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22124.4 -> To Version 7.0.0-beta.22153.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220304.3 (#1847) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22153.1 -> To Version 7.0.0-beta.22154.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220307.6 (#1849) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22154.3 -> To Version 7.0.0-beta.22157.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * fixed missing NullableEnabled property in the RazorPageModel (#1854) * fixed missing NullableEnabled property in the RazorPageModel * removing Debugger.Launch() * [main] Update dependencies from dotnet/arcade (#1853) * Update dependencies from https://github.com/dotnet/arcade build 20220316.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22157.6 -> To Version 7.0.0-beta.22166.1 * Update dependencies from https://github.com/dotnet/arcade build 20220317.4 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22157.6 -> To Version 7.0.0-beta.22167.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * minimal api endpoints (#1848) * initial commit. basic scenarios work. * both EF and no EF scenarios with Open API flag work. * Added unit and integration tests for minimal api scenario * minor fixes * updating build pool for azure-pipelines.yml * more fixes * removing linux and mac method for now. * minor changes - added OpenAPI Program.cs changes, correct namespaces. * PR comments. * refactored MinimalApiGenerator.ModifyProgramCs * Update dependencies from https://github.com/dotnet/arcade build 20220318.2 (#1855) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22167.4 -> To Version 7.0.0-beta.22168.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20220321.2 (#1856) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22168.2 -> To Version 7.0.0-beta.22171.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * only adding Ef usings when DbContextNamespace is present (#1857) * Add Calls Graph support to Blazor WASM config (#1851) * Add Calls Graph support to Blazor WASM config * Remove downstreamApi * Store codefiles as .txt * Update dependencies from https://github.com/dotnet/arcade build 20220329.1 (#1862) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.22171.2 -> To Version 7.0.0-beta.22179.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Cherry picking main into release/6.0 (#1688) * updated package versions to GA for package dependencies (#1673) * updated package versions to GA for package dependencies * updated sdk version in global.json * reverted a couple versions * Fix spacing * Use MicrosoftGraph for appsettings * Fix scopes * revert scopes appsettings field * Update code modifier configs * [main] Update dependencies from dotnet/arcade (#1663) * Update dependencies from https://github.com/dotnet/arcade build 20211007.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21507.3 * Update dependencies from https://github.com/dotnet/arcade build 20211008.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21508.1 * Update dependencies from https://github.com/dotnet/arcade build 20211011.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21511.1 * Update dependencies from https://github.com/dotnet/arcade build 20211012.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21512.3 * Update dependencies from https://github.com/dotnet/arcade build 20211013.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21513.5 * Update dependencies from https://github.com/dotnet/arcade build 20211014.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21514.3 * Update dependencies from https://github.com/dotnet/arcade build 20211015.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21515.2 * Update dependencies from https://github.com/dotnet/arcade build 20211018.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21518.1 * Update dependencies from https://github.com/dotnet/arcade build 20211018.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21518.6 * Update dependencies from https://github.com/dotnet/arcade build 20211019.8 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21519.8 * Update dependencies from https://github.com/dotnet/arcade build 20211020.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21520.1 * Update dependencies from https://github.com/dotnet/arcade build 20211021.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21521.5 * Update dependencies from https://github.com/dotnet/arcade build 20211022.2 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21522.2 * Update dependencies from https://github.com/dotnet/arcade build 20211024.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21524.1 * Update dependencies from https://github.com/dotnet/arcade build 20211026.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21526.1 * Update dependencies from https://github.com/dotnet/arcade build 20211027.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21527.1 * Update dependencies from https://github.com/dotnet/arcade build 20211027.5 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21527.5 * Update dependencies from https://github.com/dotnet/arcade build 20211028.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21528.3 * Update dependencies from https://github.com/dotnet/arcade build 20211029.1 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21529.1 * updated xunit version Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: deepchoudhery <decho@microsoft.com> * Update dependencies from https://github.com/dotnet/arcade build 20211102.1 (#1681) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21529.1 -> To Version 7.0.0-beta.21552.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * removing node type check, we shouldn't care what type of node. (#1684) * Update Web API code modifier config * code change fixes for dotnet-msidentity scenarios (#1683) * code change fixes for dotnet-msidentity scenarios * minor fixes * fixed spacing in webapi msidentity config. Co-authored-by: Zach Halzel <zahalzel@microsoft.com> Co-authored-by: zahalzel <75647613+zahalzel@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * 6.0.1 cherry picks (#1730) * Add models from other projects [Regression] (#1718) * finding missing workspace files * using models from different projects enabled. * cleaning up more. * updated Versions.props * not adding/forcing Account.Logout.cshtml if blazor project already adds it. (#1721) * Adding #nullable disable to scaffolding templates (#1723) * checking for nullable msbuild property and adding #nullable disable to tempaltes * added #nulalble disable logic for NewLocalDbContext * updated macOS image * fixed mistake with azure images * updating Versions.MSIdentity.props to 1.0.1 * Enable Microsoft Graph option for Blazor Server (#1719) Enable Microsoft Graph option for Blazor Server, add .razor modification functionality Co-authored-by: zahalzel <75647613+zahalzel@users.noreply.github.com> * added MSBuildLocator.RegisterDefaults call to load Microsoft.Build assemblies (#1741) * Servicing release for dotnet-aspnet-codegenerator and dotnet-msidentity (#1816) * Code updates for blazor server Downstream API option (#1767) * Add blazor server, and some code refactors * updating System package versions due to security vulnerabilities (#1781) * updating System package versions due to security vulnerabilities * revert package version for test. * potential fix? * fixed all compliance issues. * clean up * Refactor ProjectModifier and remove calls to Directory.EnumerateFiles (#1782) * Removing EnumerateDirectories, other refactors * Create and Update Blazor Wasm App Registrations (#1793) * scripts and gitignore * Update redirect uris * create and update Blazor Wasm apps * Process callback paths for remote URIs * Add comments and refactor for better readability * String updates * Fix updating bug, update strings * Blazor Server: Code updates for Microsoft Graph and Downstream API options (#1798) Adding code updates for blazor server non-auth templates * Blazor Wasm: Code Updates and AppSettings updates (#1805) * Blazor Wasm: Code Updates and AppSettings updates * App Settings and Code Modification updates * App Settings and Code Modification updates * App Settings and Code Modification updates * App Settings and Code Modification updates * Update AzureAdProperties logic Address PR comments Refactor tests * Update version to 1.0.2, add reference to Nuget package * Refactor projectDescriptionReader logic * Downstream API fixes * Add AppSettings modification to CodeUpdate option * not throwing exception on invalid bootstrap versions. (#1814) * not throwing exception on invalid bootstrap . * minor fix * bump up dotnet-aspnet-codegenerator version. Co-authored-by: zahalzel <75647613+zahalzel@users.noreply.github.com> * minor fixes * bumping up version Co-authored-by: Zach Halzel <zahalzel@microsoft.com> Co-authored-by: zahalzel <75647613+zahalzel@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Christopher Yeleighton <ne01026@shark.2a.pl> Co-authored-by: DaniRzV <danirzv@gmail.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Add Command.ToString (returning file name and arguments)
Add Command._logger
Add LogMessage to Execute (before starting)
Fixes #1736
Tracing is not essential, so no test.