Skip to content

Commit

Permalink
Code signing issues "workaround" (#566)
Browse files Browse the repository at this point in the history
* Update deploy.yml

* Sign one at a time maybe?

* It worked, fixes for PR

* cont'd
  • Loading branch information
Perksey committed Aug 9, 2021
1 parent 0581eda commit f2ab12f
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ jobs:
- name: Upload Signed Artifacts to Actions
uses: actions/upload-artifact@v2.2.4
with:
name: unsigned_nupkgs
name: signed_nupkgs
path: "build/output_packages/*.nupkg"
if-no-files-found: warn
31 changes: 17 additions & 14 deletions build/nuke/Build.cs
Original file line number Diff line number Diff line change
Expand Up @@ -443,20 +443,23 @@ async Task PushPackages()
DotNetToolInstall(s => s.SetToolInstallationPath(basePath / "tool").SetPackageName("SignClient"));
}

StartProcess
(
execPath,
"sign " +
$"--baseDirectory {PackageDirectory} " +
"--input \"**/*.nupkg\" " +
$"--config \"{basePath / "config.json"}\" " +
$"--filelist \"{basePath / "filelist.txt"}\" " +
$"--user \"{SignUsername}\" " +
$"--secret \"{SignPassword}\" " +
"--name \"Silk.NET\" " +
"--description \"Silk.NET\" " +
"--descriptionUrl \"https://github.com/dotnet/Silk.NET\""
).AssertZeroExitCode();
foreach (var pkg in Packages)
{
StartProcess
(
execPath,
"sign " +
$"--baseDirectory {PackageDirectory} " +
$"--input \"{pkg}\" " +
$"--config \"{basePath / "config.json"}\" " +
$"--filelist \"{basePath / "filelist.txt"}\" " +
$"--user \"{SignUsername}\" " +
$"--secret \"{SignPassword}\" " +
"--name \"Silk.NET\" " +
"--description \"Silk.NET\" " +
"--descriptionUrl \"https://github.com/dotnet/Silk.NET\""
).AssertZeroExitCode();
}
}

var allFiles = Packages.Select((x, i) => new {Index = i, Value = x})
Expand Down

0 comments on commit f2ab12f

Please sign in to comment.