Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPIRV-Reflect bindings #1403

Merged
merged 45 commits into from
May 28, 2023
Merged

Add SPIRV-Reflect bindings #1403

merged 45 commits into from
May 28, 2023

Conversation

Beyley
Copy link
Contributor

@Beyley Beyley commented Apr 13, 2023

Summary of the PR

Adds SPIRV-Reflect bindings

Related issues, Discord discussions, or proposals

Closes #979

Further Comments

Uses Zig to cross compile a shared library, same as the linux HLSL compiler

@Beyley Beyley force-pushed the feature/spirv-reflect branch 3 times, most recently from b6a7a11 to 2492edf Compare April 14, 2023 00:48
@Khitiara
Copy link
Contributor

Looks like the functions are keeping the Reflect prefix, not sure if thats intended or not

@Beyley Beyley marked this pull request as ready for review April 14, 2023 00:51
@Beyley Beyley requested a review from a team as a code owner April 14, 2023 00:51
@Beyley
Copy link
Contributor Author

Beyley commented Apr 14, 2023

Looks like the functions are keeping the Reflect prefix, not sure if thats intended or not

good point, ill change the prefix and see if that helps

@Beyley
Copy link
Contributor Author

Beyley commented Apr 14, 2023 •
edited
Loading

Looks like the functions are keeping the Reflect prefix, not sure if thats intended or not

good point, ill change the prefix and see if that helps

That breaks enums and structs, which now eroneously have a spv prefix, so theres no really an easy way to fix this unless you fix all the function names or fix all the enums and structs by hand

@Khitiara
Copy link
Contributor

Khitiara commented Apr 14, 2023 •
edited
Loading

Looks like the functions are keeping the Reflect prefix, not sure if thats intended or not

good point, ill change the prefix and see if that helps

That breaks enums and structs, which now eroneously have a spv prefix, so theres no really an easy way to fix this unless you fix all the function names or fix all the enums and structs by hand

not a big issue, just figured id mention it

@Beyley
Copy link
Contributor Author

Beyley commented Apr 14, 2023

Moving back to draft, i need to separate spirv.h into its own project, SPIRV-Cross also depends on spirv.h, so tomorrow ill split it off into a Silk.NET.SPIRV project, so that SPIRV-Cross and SPIRV-Reflect can both reference it

@Beyley Beyley marked this pull request as draft April 14, 2023 08:12
@Beyley Beyley force-pushed the feature/spirv-reflect branch 2 times, most recently from de5a021 to 7403a14 Compare April 14, 2023 20:45
@Beyley Beyley marked this pull request as ready for review April 14, 2023 20:45
@Beyley Beyley force-pushed the feature/spirv-reflect branch 2 times, most recently from d9fee24 to 43f59c1 Compare April 19, 2023 09:12
@Beyley Beyley mentioned this pull request Apr 21, 2023
Closed
Perksey
Perksey requested changes Apr 21, 2023
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed every single file which is a first for a bindings PR

generator.json Outdated Show resolved Hide resolved
generator.json Outdated Show resolved Hide resolved
src/SPIRV/Silk.NET.SPIRV/Enums/FunctionParameterAttribute.gen.cs Show resolved Hide resolved
src/SPIRV/Silk.NET.SPIRV/Enums/ImageChannelOrder.gen.cs Show resolved Hide resolved
src/SPIRV/Silk.NET.SPIRVReflect/Enums/AnonymousEnumSpirvReflectL261C1.gen.cs Outdated Show resolved Hide resolved
Perksey
Perksey approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending tests

silkdotnet and others added 7 commits May 1, 2023 18:57
@silkdotnet @dotnet-bot @Beyley
New binaries for DXVK on Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed M…
dcbd080 
…ar 29 16:11:05 UTC 2023 (#1436)

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot @Beyley
New binaries for Assimp on Microsoft Windows 10.0.20348 (#1435)
a3fe17d 
Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot @Beyley
New binaries for GLFW on Microsoft Windows 10.0.20348 (#1434)
7137215 
Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot @Beyley
New binaries for Vulkan Loader on Microsoft Windows 10.0.20348 (#1433)
1ed44c9 
Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot @Beyley
New binaries for SPIRV-Reflect on Linux 5.15.0-1036-azure #43-Ubuntu …
5f751b4 
…SMP Wed Mar 29 16:11:05 UTC 2023 (#1432)

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@Beyley
Look Gordon, a whitespace change!
dfff834
@Beyley
If i make another commit will it work
77544b9
Beyley and others added 6 commits May 1, 2023 20:27
@Beyley
Update WebGPU experiments to new naming
1b0c7fe
@silkdotnet @dotnet-bot
New binaries for DXVK on Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed M…
701e0fb 
…ar 29 16:11:05 UTC 2023 (#1445)

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot
New binaries for Assimp on Microsoft Windows 10.0.20348 (#1444)
c12d285 
Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot
Update GLFW binaries (#1443)
4092d91 
* New binaries for GLFW on Microsoft Windows 10.0.20348

* New binaries for GLFW on Darwin 21.6.0 Darwin Kernel Version 21.6.0: Thu Mar  9 20:08:59 PST 2023; root:xnu-8020.240.18.700.8~1/RELEASE_X86_64

---------

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot
New binaries for Vulkan Loader on Microsoft Windows 10.0.20348 (#1442)
3ce1a0a 
Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@silkdotnet @dotnet-bot
New binaries for SPIRV-Reflect on Linux 5.15.0-1036-azure #43-Ubuntu …
33d75e6 
…SMP Wed Mar 29 16:11:05 UTC 2023 (#1441)

Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
@Beyley Beyley requested a review from ThomasMiz as a code owner May 3, 2023 00:37
Perksey
Perksey approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I PRESENT UNTO THEE MY LARGE GREEN TICK

@Perksey Perksey enabled auto-merge (squash) May 28, 2023 19:59
@Perksey Perksey merged commit be7bb47 into main May 28, 2023
4 checks passed
@Perksey Perksey deleted the feature/spirv-reflect branch May 28, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

@HurricanKai HurricanKai Awaiting requested review from HurricanKai HurricanKai is a code owner

@ThomasMiz ThomasMiz Awaiting requested review from ThomasMiz ThomasMiz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Silk.NET Development Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spirv-Reflect Bindings
4 participants
@Beyley @Khitiara @Perksey @silkdotnet