Build Tools .Net Core 3 #42

HurricanKai · 2019-08-11T13:37:44Z

Summary of the PR

Updates Build Tools to .Net Core 3
Resolving any Issues

Related issues, Discord discussions, or proposals

See #41 for further information

Further Comments

HurricanKai · 2019-08-11T14:13:24Z

Not clear why Azure Pipelines is failing. Seems to be the nuget feed?
Else ready to review.

…to NetCore3

HurricanKai · 2019-08-11T16:05:24Z

There we go. Pipelines works.

Perksey · 2019-08-11T16:06:23Z

Have you tried a full run of the BuildTools?

./generator.bat build/binder_scripts/fullrun.json

HurricanKai · 2019-08-11T16:08:38Z

Yep, I did. Set it up as my Run config in Rider.

Perksey

Awesome stuff. Approved, but I'll probably do a bit of a clean-up later down the line.

Perksey · 2019-08-11T16:13:37Z

src/Core/BuildTools/GLXmlConvert/Construction/ParsingHelpers.cs

@@ -263,22 +259,44 @@ public static Count ParseCountSignature
                return new Count(valueReferenceName);
            }

-            // Some counts are a value reference along with some sort of numerical operation - let's skip forward in
-            // the string until we hit the first invalid character, and see if the rest are just numbers or math ops
-            var dataBeforeFirstInvalidCharacter = new string(countData.TakeWhile(char.IsLetterOrDigit).ToArray());


We should reinstate these 2 lines as I liked the if statements we had before. Split the parsing logic into its own function, and then do if (SyntaxFacts.IsValidIdentifier(dataBeforeFirstInvalidCharacter) && IsMath(dataAfterFirstInvalidCharater)

Added a small commit to do this, does that work?

Yes that works nicely :) open another PR as I've already merged this one :P

…SMP Tue Feb 28 19:41:23 UTC 2023

…eb 28 19:41:23 UTC 2023

…SMP Tue Feb 28 19:41:23 UTC 2023

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

…eb 28 19:41:23 UTC 2023

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

…SMP Tue Feb 28 19:41:23 UTC 2023

…eb 28 19:41:23 UTC 2023

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1414) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1414) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

* Add SPIRV-Reflect submodule * Add SPIRVReflect native project * Update vkd3d shader compiler build to latest Zig * Add CI job to build SPIRV-Reflect * New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * Add SPIRV-Reflect native package to solution file * Add SPIRV-Reflect bindings * Split spirv.h into its own project * BuildTools: Use underscore converted trimming name when enum trimming This attempts to fix spirv.h enums without needing manual hacks Currently broken * Fixed in some ways, broken in others. * BuildTools: Dont check for duplicate old/new enum names with no-obsolete-enum control descriptor This fixes the Dim enum from SPIRV and Gamma enum from D2D * BuildTools: Fix LenientUnderscore with FormatR32ui SpvImageFormatR32ui now becomes Spv_Image_Format_R32ui instead of Spv_Image_FormatR32ui * New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue Feb 28 19:41:23 UTC 2023 (#1414) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * Rename SPIRVReflect to SPIRV.Reflect, change generation prefix This also excludes a C++ class `ShaderModule` which was eroneously generated And renames all the structs which conflict with vulkan types after the prefix change * Rename SPIRV class to Spv This removes potential problems from intersecting namespace and class names * SPIRV.Reflect: Reference base SPIRV project * SPIRV.Reflect: Rename anonymous enums to Constants * WebGPU: Use new enum names * Regenerate bindings * BuildTools: Add prefix overrides for enum trimming * SPIRV: Specify a prefix override to fix ImageChannelOrder * Native: Rename Silk.NET.SPIRVReflect.Native It now reflects the new name of the source package it belongs to * SPIRV.Reflect.Tests: Add basic InputVariables test * New binaries for DXVK on Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 (#1436) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for Assimp on Microsoft Windows 10.0.20348 (#1435) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for GLFW on Microsoft Windows 10.0.20348 (#1434) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for Vulkan Loader on Microsoft Windows 10.0.20348 (#1433) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for SPIRV-Reflect on Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 (#1432) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * Look Gordon, a whitespace change! * If i make another commit will it work * Update WebGPU experiments to new naming * New binaries for DXVK on Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 (#1445) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for Assimp on Microsoft Windows 10.0.20348 (#1444) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * Update GLFW binaries (#1443) * New binaries for GLFW on Microsoft Windows 10.0.20348 * New binaries for GLFW on Darwin 21.6.0 Darwin Kernel Version 21.6.0: Thu Mar 9 20:08:59 PST 2023; root:xnu-8020.240.18.700.8~1/RELEASE_X86_64 --------- Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for Vulkan Loader on Microsoft Windows 10.0.20348 (#1442) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * New binaries for SPIRV-Reflect on Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 (#1441) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> * Add copyright header to SPIRV-Reflect test * Attempt to bring back the 2.17 enum names as deprecated * BuildTools changes for bringing back the 2.17 enum names as deprecated * Regenerate bindings for efd969d * Account for one more edge case in the deprecated name resurgence * Pumped Up Kicks but it's not Pumped Up Kicks and I eat a shoe box * Fix lack of obsoletion message * Update sln --------- Co-authored-by: silkdotnet <85832961+silkdotnet@users.noreply.github.com> Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com> Co-authored-by: Dylan Perks <dylanperks23@gmail.com>

HurricanKai added 4 commits August 11, 2019 15:36

Start of Build Tools .Net Core 3

14ebccb

Set .Net Core Version

57b9063

Replace COMPSIZE Regex Parsing with Span Parsing

f5bc1b2

Replace Regex expression parsing with Span

7332959

HurricanKai changed the title ~~[WIP] Build Tools .Net Core 3~~ Build Tools .Net Core 3 Aug 11, 2019

HurricanKai added 2 commits August 11, 2019 16:07

Update Azure Pipelines

c6267de

Simplify Azure Piplines

74fe0eb

Perksey and others added 4 commits August 11, 2019 16:49

Merge branch 'master' into NetCore3

b0ef9a8

Update azure-pipelines.yml

45cadd0

Retrigger Pipelines

7c6c46e

Merge branch 'NetCore3' of https://github.com/HurricanKai/Silk.NET in…

0c524c4

…to NetCore3

Perksey approved these changes Aug 11, 2019

View reviewed changes

Perksey merged commit 0b48e4b into dotnet:master Aug 11, 2019

This was referenced Aug 11, 2019

Build Tools Refactoring #44

Merged

Build tools Update to .Net Core 3 #41

Closed

Perksey added the area-Core/BuildTools label Apr 10, 2021

silkdotnet pushed a commit that referenced this pull request Apr 13, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

e1d519b

…SMP Tue Feb 28 19:41:23 UTC 2023

silkdotnet pushed a commit that referenced this pull request Apr 13, 2023

New binaries for Wgpu on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue F…

ac5a734

…eb 28 19:41:23 UTC 2023

silkdotnet pushed a commit that referenced this pull request Apr 13, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

0d54466

…SMP Tue Feb 28 19:41:23 UTC 2023

Beyley pushed a commit that referenced this pull request Apr 13, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

c927281

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

silkdotnet pushed a commit that referenced this pull request Apr 13, 2023

New binaries for Wgpu on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue F…

7ae5343

…eb 28 19:41:23 UTC 2023

silkdotnet pushed a commit that referenced this pull request Apr 13, 2023

New binaries for DXVK on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue F…

5a28d91

…eb 28 19:41:23 UTC 2023

Beyley pushed a commit that referenced this pull request Apr 19, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

6efae97

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

silkdotnet pushed a commit that referenced this pull request Apr 19, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

7d7fca5

…SMP Tue Feb 28 19:41:23 UTC 2023

silkdotnet pushed a commit that referenced this pull request Apr 19, 2023

New binaries for Wgpu on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue F…

1a9a84b

…eb 28 19:41:23 UTC 2023

silkdotnet pushed a commit that referenced this pull request Apr 19, 2023

New binaries for DXVK on Linux 5.15.0-1035-azure #42-Ubuntu SMP Tue F…

58fd412

…eb 28 19:41:23 UTC 2023

Beyley pushed a commit that referenced this pull request Apr 21, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

80f88c6

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1414) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

Beyley pushed a commit that referenced this pull request May 2, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

f8f1c78

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1406) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

Beyley pushed a commit that referenced this pull request May 2, 2023

New binaries for SPIRV-Reflect on Linux 5.15.0-1035-azure #42-Ubuntu …

1dcad5a

…SMP Tue Feb 28 19:41:23 UTC 2023 (#1414) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Tools .Net Core 3 #42

Build Tools .Net Core 3 #42

HurricanKai commented Aug 11, 2019

HurricanKai commented Aug 11, 2019

HurricanKai commented Aug 11, 2019

Perksey commented Aug 11, 2019

HurricanKai commented Aug 11, 2019

Perksey left a comment

Perksey Aug 11, 2019

HurricanKai Aug 11, 2019 •

edited

Perksey Aug 11, 2019

Build Tools .Net Core 3 #42

Build Tools .Net Core 3 #42

Conversation

HurricanKai commented Aug 11, 2019

Summary of the PR

Related issues, Discord discussions, or proposals

Further Comments

HurricanKai commented Aug 11, 2019

HurricanKai commented Aug 11, 2019

Perksey commented Aug 11, 2019

HurricanKai commented Aug 11, 2019

Perksey left a comment

Choose a reason for hiding this comment

Perksey Aug 11, 2019

Choose a reason for hiding this comment

HurricanKai Aug 11, 2019 • edited

Choose a reason for hiding this comment

Perksey Aug 11, 2019

Choose a reason for hiding this comment

HurricanKai Aug 11, 2019 •

edited